From 20a4648f3234051ae47c6f43b4fbde0443140e78 Mon Sep 17 00:00:00 2001 From: gcornut Date: Wed, 24 Jan 2024 11:14:26 +0100 Subject: [PATCH] chore(types): document button on click prop --- packages/lumx-react/src/components/button/ButtonRoot.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/lumx-react/src/components/button/ButtonRoot.tsx b/packages/lumx-react/src/components/button/ButtonRoot.tsx index 8536f31ea..d2eb70367 100644 --- a/packages/lumx-react/src/components/button/ButtonRoot.tsx +++ b/packages/lumx-react/src/components/button/ButtonRoot.tsx @@ -1,4 +1,4 @@ -import React, { AriaAttributes, ButtonHTMLAttributes, DetailedHTMLProps, forwardRef, RefObject } from 'react'; +import React, { AriaAttributes, forwardRef, RefObject } from 'react'; import isEmpty from 'lodash/isEmpty'; @@ -10,7 +10,7 @@ import { Comp, GenericProps, HasTheme } from '@lumx/react/utils/type'; import { handleBasicClasses } from '@lumx/react/utils/className'; import { renderLink } from '@lumx/react/utils/renderLink'; -type HTMLButtonProps = DetailedHTMLProps, HTMLButtonElement>; +type HTMLButtonProps = React.ComponentProps<'button'>; /** * Button size definition. @@ -35,6 +35,8 @@ export interface BaseButtonProps isSelected?: boolean; /** Native button name property. */ name?: string; + /** On click event callback */ + onClick: HTMLButtonProps['onClick']; /** Size variant. */ size?: ButtonSize; /** Native anchor target property. */