fix(popover): fix popper warning on margin style from visually-hidden

gcornut · gcornut · commit 93ce3196183a · 2025-07-10T13:42:18.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+-   `Popover` & `Tooltip`: fix popper warning on margin style applied by class `.visually-hidden`.
+
 ## [3.15.0][] - 2025-07-02
 
 ### Fixed
diff --git a/packages/lumx-core/src/scss/core/base/_helpers.scss b/packages/lumx-core/src/scss/core/base/_helpers.scss
@@ -33,3 +33,8 @@
     clip: rect(0 0 0 0) !important;
     border: 0 !important;
 }
+
+/** Need to remove the margin style on popper elements or else we get warnings in the console */
+.lumx-popover.visually-hidden, .lumx-tooltip.visually-hidden {
+    margin: revert !important;
+}

Original file line number	Diff line number	Diff line change
`@@ -33,3 +33,8 @@`
`33`	`33`	`clip: rect(0 0 0 0) !important;`
`34`	`34`	`border: 0 !important;`
`35`	`35`	`}`
	`36`	`+`
	`37`	`+/** Need to remove the margin style on popper elements or else we get warnings in the console */`
	`38`	`+.lumx-popover.visually-hidden, .lumx-tooltip.visually-hidden {`
	`39`	`+ margin: revert !important;`
	`40`	`+}`