Skip to content

Commit 83c5491

Browse files
committed
refactor(types): fix type issues for React 18
1 parent a9c0442 commit 83c5491

File tree

36 files changed

+85
-11
lines changed

36 files changed

+85
-11
lines changed

packages/lumx-react/src/components/alert-dialog/AlertDialog.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ export interface AlertDialogProps extends Omit<DialogProps, 'header' | 'footer'>
3737
onClick(): void;
3838
label: string;
3939
};
40+
/**
41+
* Children
42+
*/
43+
children?: React.ReactNode;
4044
}
4145

4246
/**

packages/lumx-react/src/components/button/ButtonGroup.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ import { forwardRef } from '@lumx/react/utils/react/forwardRef';
99
/**
1010
* Defines the props of the component
1111
*/
12-
export type ButtonGroupProps = GenericProps;
12+
export interface ButtonGroupProps extends GenericProps {
13+
/**
14+
* Children
15+
*/
16+
children?: React.ReactNode;
17+
}
1318

1419
/**
1520
* Component display name.

packages/lumx-react/src/components/button/ButtonRoot.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export interface BaseButtonProps
4444
type?: HTMLButtonProps['type'];
4545
/** Custom react component for the link (can be used to inject react router Link). */
4646
linkAs?: 'a' | any;
47+
/** Children */
48+
children?: React.ReactNode;
4749
}
4850

4951
export interface ButtonRootProps extends BaseButtonProps {

packages/lumx-react/src/components/chip/Chip.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ export interface ChipProps extends GenericProps, HasTheme {
4141
onAfterClick?: MouseEventHandler;
4242
/** On "before" element clicked callback. */
4343
onBeforeClick?: MouseEventHandler;
44+
/** Children */
45+
children?: React.ReactNode;
4446
}
4547

4648
/**

packages/lumx-react/src/components/dialog/Dialog.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ export interface DialogProps extends GenericProps {
6161
onVisibilityChange?(isVisible: boolean): void;
6262
/** whether to disable the scroll on the body or not */
6363
disableBodyScroll?: boolean;
64+
/** Children */
65+
children?: React.ReactNode;
6466
}
6567

6668
export type DialogSizes = Extract<Size, 'tiny' | 'regular' | 'big' | 'huge'>;

packages/lumx-react/src/components/expansion-panel/ExpansionPanel.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ export interface ExpansionPanelProps extends GenericProps, HasTheme {
3838
Omit<IconButtonProps, 'label' | 'onClick' | 'icon' | 'emphasis' | 'color'>;
3939
/** On toggle open or close callback. */
4040
onToggleOpen?(shouldOpen: boolean, event: React.MouseEvent): void;
41+
/** Children */
42+
children?: React.ReactNode;
4143
}
4244

4345
/**

packages/lumx-react/src/components/grid/Grid.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ export interface GridProps extends GenericProps {
2323
hAlign?: Alignment;
2424
/** Gutter size. */
2525
gutter?: GridGutterSize;
26+
/** Children */
27+
children?: React.ReactNode;
2628
}
2729

2830
/**

packages/lumx-react/src/components/grid/GridItem.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ export interface GridItemProps extends GenericProps {
1919
order?: Columns;
2020
/** Width. */
2121
width?: Columns;
22+
/** Children */
23+
children?: React.ReactNode;
2224
}
2325

2426
/**

packages/lumx-react/src/components/heading/Heading.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ export interface HeadingProps extends Partial<TextProps> {
1818
* Display a specific heading level instead of the one provided by parent context provider.
1919
*/
2020
as?: HeadingElement;
21+
/**
22+
* Children
23+
*/
24+
children?: React.ReactNode;
2125
}
2226

2327
/**

packages/lumx-react/src/components/inline-list/InlineList.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ export interface InlineListProps extends GenericProps {
2727
* Activate line wrap on overflow.
2828
*/
2929
wrap?: boolean;
30+
/**
31+
* Children
32+
*/
33+
children?: React.ReactNode;
3034
}
3135

3236
/**

0 commit comments

Comments
 (0)