Skip to content

Commit 0a46d99

Browse files
committed
fix(icon-button): remove unsupported children prop type
1 parent 9b1cbb6 commit 0a46d99

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- `IconButton`: remove the children prop as it's not actually supported by the component
13+
1014
## [3.11.0][] - 2025-02-05
1115

1216
### Added

packages/lumx-react/src/components/button/Button.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { ReactNode } from 'react';
1+
import React from 'react';
22

33
import classNames from 'classnames';
44
import isEmpty from 'lodash/isEmpty';
@@ -21,14 +21,14 @@ export const ButtonEmphasis = Emphasis;
2121
* Defines the props of the component.
2222
*/
2323
export interface ButtonProps extends BaseButtonProps {
24-
/** Button content. */
25-
children?: ReactNode;
2624
/** Left icon (SVG path). */
2725
leftIcon?: string;
2826
/** Right icon (SVG path). */
2927
rightIcon?: string;
3028
/** When `true`, the button gets as large as possible. */
3129
fullWidth?: boolean;
30+
/** Children */
31+
children?: React.ReactNode;
3232
}
3333

3434
/**

packages/lumx-react/src/components/button/ButtonRoot.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ export interface BaseButtonProps
4444
type?: HTMLButtonProps['type'];
4545
/** Custom react component for the link (can be used to inject react router Link). */
4646
linkAs?: 'a' | any;
47-
/** Children */
48-
children?: React.ReactNode;
4947
}
5048

5149
export interface ButtonRootProps extends BaseButtonProps {

0 commit comments

Comments
 (0)