Skip to content

Continuous range for discretize area #91

@sbriseid

Description

@sbriseid

Hi @lucidrains and @MarcusLoppe!

It seems that the area discretizer has an inefficient bin usage for the triangle mesh, using only the first half:
self.discretize_area = partial(discretize, num_discrete = num_discrete_area, continuous_range = (0., (hi - lo) ** 2))

This is correct for quad meshes, but for triangles there should be a 0.5 factor for the upper limit:
continuous_range = (0., (hi - lo) ** 2) if quads else (0., 0.5 * (hi - lo) ** 2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions