fix: edge case bug when file size is 0 (file empty) - TODO: need to write a unit test

Signed-off-by: Stephen L. <LRQ3000@gmail.com>

Author: lrq3000

pyFileFixity/header_ecc.py

@@ -468,7 +468,7 @@ def main(argv=None, command=None):
     ptee.write("Precomputing done.")
     if generate: # show statistics only if generating an ecc file
         # TODO: add the size of the ecc format header? (arguments string + PYHEADERECC identifier)
-        total_pred_percentage = sizeheaders * 100 / sizetotal
+        total_pred_percentage = sizeheaders * 100 / max(1, sizetotal)
         ptee.write("Total ECC size estimation: %s = %g%% of total files size %s." % (sizeof_fmt(sizeheaders), total_pred_percentage, sizeof_fmt(sizetotal)))
         ptee.write("Details: resiliency of %i%%: For the header (first %i characters) of each file: each block of %i chars will get an ecc of %i chars (%i errors or %i erasures)." % (resilience_rate*100, header_size, ecc_params["message_size"], ecc_params["ecc_size"], int(ecc_params["ecc_size"] / 2), ecc_params["ecc_size"]))
 

pyFileFixity/replication_repair.py

@@ -574,7 +574,7 @@ def main(argv=None, command=None):
     # == Precomputation of ecc file size
     # Precomputing is important so that the user can know what size to expect before starting (and how much time it will take...).
     filescount = 0
-    sizetotal = 0
+    #sizetotal = 0 # TODO: unused
     sizeheaders = 0
     visitedfiles = {}
     ptee.write("Precomputing list of files and predicted statistics...")
@@ -591,10 +591,10 @@ def main(argv=None, command=None):
                 filescount = filescount + 1
                 # Add the file to the list of already visited files
                 visitedfiles[relfilepath] = True
-                # Get the current file's size
-                size = os.stat(filepath).st_size
-                # Compute total size of all files
-                sizetotal = sizetotal + size
+                # Get the current file's size # TODO: unused
+                #size = os.stat(filepath).st_size
+                # Compute total size of all files # TODO: unused
+                #sizetotal = sizetotal + size
             prebar.update()
     prebar.close()
     ptee.write("Precomputing done.")

pyFileFixity/structural_adaptive_ecc.py

@@ -517,6 +517,7 @@ def main(argv=None, command=None):
     ptee.write("Precomputing done.")
     if generate: # show statistics only if generating an ecc file
         # TODO: add the size of the ecc format header? (arguments string + PYHEADERECC identifier)
+        #total_pred_percentage = sizeecc * 100 / max(1, sizetotal)
         total_pred_percentage = sizeecc * 100 / sizetotal
         ptee.write("Total ECC size estimation: %s = %g%% of total files size %s." % (sizeof_fmt(sizeecc), total_pred_percentage, sizeof_fmt(sizetotal)))
         ptee.write("Details per stage:")