Merge pull request #371 from pe-jot/bugfix/DynamicJsonDocument_deprecated_in_ArduinoJSON_#356

Bugfix/dynamic json document deprecated in arduino json #356

Author: peterus

src/ConfigurationManagement/configuration.cpp

@@ -23,7 +23,7 @@ void ConfigurationManagement::readConfiguration(logging::Logger &logger, Configu
     logger.log(logging::LoggerLevel::LOGGER_LEVEL_ERROR, MODULE_NAME, "Failed to open file for reading, using default configuration.");
     return;
   }
-  DynamicJsonDocument  data(2048);
+  JsonDocument         data;
   DeserializationError error = deserializeJson(data, file);
   if (error) {
     logger.log(logging::LoggerLevel::LOGGER_LEVEL_WARN, MODULE_NAME, "Failed to read file, using default configuration.");
@@ -44,7 +44,7 @@ void ConfigurationManagement::writeConfiguration(logging::Logger &logger, Config
     logger.log(logging::LoggerLevel::LOGGER_LEVEL_ERROR, MODULE_NAME, "Failed to open file for writing...");
     return;
   }
-  DynamicJsonDocument data(2048);
+  JsonDocument data;
 
   writeProjectConfiguration(conf, data);
 

src/ConfigurationManagement/configuration.h

@@ -22,8 +22,8 @@ class ConfigurationManagement {
   void writeConfiguration(logging::Logger &logger, Configuration &conf);
 
 private:
-  virtual void readProjectConfiguration(DynamicJsonDocument &data, Configuration &conf)  = 0;
-  virtual void writeProjectConfiguration(Configuration &conf, DynamicJsonDocument &data) = 0;
+  virtual void readProjectConfiguration(JsonDocument &data, Configuration &conf)  = 0;
+  virtual void writeProjectConfiguration(Configuration &conf, JsonDocument &data) = 0;
 
   const String mFilePath;
 };

src/TaskMQTT.cpp

@@ -29,7 +29,7 @@ bool MQTTTask::loop(System &system) {
   if (!_toMQTT.empty()) {
     std::shared_ptr<APRSMessage> msg = _toMQTT.getElement();
 
-    DynamicJsonDocument data(1024);
+    JsonDocument data;
     data["source"]      = msg->getSource();
     data["destination"] = msg->getDestination();
     data["path"]        = msg->getPath();

src/project_configuration.cpp

@@ -4,7 +4,7 @@
 
 #include "project_configuration.h"
 
-void ProjectConfigurationManagement::readProjectConfiguration(DynamicJsonDocument &data, Configuration &conf) {
+void ProjectConfigurationManagement::readProjectConfiguration(JsonDocument &data, Configuration &conf) {
   if (data.containsKey("callsign"))
     conf.callsign = data["callsign"].as<String>();
 
@@ -119,7 +119,7 @@ void ProjectConfigurationManagement::readProjectConfiguration(DynamicJsonDocumen
     conf.board = data["board"].as<String>();
 }
 
-void ProjectConfigurationManagement::writeProjectConfiguration(Configuration &conf, DynamicJsonDocument &data) {
+void ProjectConfigurationManagement::writeProjectConfiguration(Configuration &conf, JsonDocument &data) {
   data["callsign"] = conf.callsign;
 
   if (!conf.network.DHCP) {
@@ -134,9 +134,9 @@ void ProjectConfigurationManagement::writeProjectConfiguration(Configuration &co
   }
 
   data["wifi"]["active"] = conf.wifi.active;
-  JsonArray aps          = data["wifi"].createNestedArray("AP");
+  JsonArray aps          = data["wifi"]["AP"].to<JsonArray>();
   for (Configuration::Wifi::AP ap : conf.wifi.APs) {
-    JsonObject v  = aps.createNestedObject();
+    JsonObject v  = aps.add<JsonObject>();
     v["SSID"]     = ap.SSID;
     v["password"] = ap.password;
   }
@@ -165,9 +165,9 @@ void ProjectConfigurationManagement::writeProjectConfiguration(Configuration &co
   data["display"]["overwrite_pin"]        = conf.display.overwritePin;
   data["display"]["turn180"]              = conf.display.turn180;
   data["ftp"]["active"]                   = conf.ftp.active;
-  JsonArray users                         = data["ftp"].createNestedArray("user");
+  JsonArray users                         = data["ftp"]["user"].to<JsonArray>();
   for (Configuration::Ftp::User u : conf.ftp.users) {
-    JsonObject v  = users.createNestedObject();
+    JsonObject v  = users.add<JsonObject>();
     v["name"]     = u.name;
     v["password"] = u.password;
   }

src/project_configuration.h

@@ -176,8 +176,8 @@ class ProjectConfigurationManagement : public ConfigurationManagement {
   }
 
 private:
-  virtual void readProjectConfiguration(DynamicJsonDocument &data, Configuration &conf) override;
-  virtual void writeProjectConfiguration(Configuration &conf, DynamicJsonDocument &data) override;
+  virtual void readProjectConfiguration(JsonDocument &data, Configuration &conf) override;
+  virtual void writeProjectConfiguration(Configuration &conf, JsonDocument &data) override;
 };
 
 #endif