Auto retry remote session polling on recoverable errors

Author: Erik Bylund

Runtime/Game/LootLockerSDKManager.cs

@@ -810,7 +810,7 @@ public static void ClearLocalSession()
         /// <summary>
         /// Start a remote session
         /// If you want to let your local user sign in using another device then you use this method. First you will get the lease information needed to allow a secondary device to authenticate.
-        /// While the process is ongoing, the remoteSessionLeaseStatusUpdate action (if one is provided) will be invoked intermittently to update you on the status of the process.
+        /// While the process is ongoing, the remoteSessionLeaseStatusUpdate action (if one is provided) will be invoked intermittently (about once a second) to update you on the status of the process.
         /// When the process has come to an end (whether successfully or not), the onComplete action will be invoked with the updated information.
         /// </summary>
         /// <param name="remoteSessionLeaseInformation">Will be invoked once to provide the lease information that the secondary device can use to authenticate</param>

Runtime/Game/Requests/RemoteSessionRequest.cs

@@ -167,7 +167,8 @@ static void OnEnterPlaymodeInEditor(EnterPlayModeOptions options)
 #endif
 
             private static readonly double _leasingProcessTimeoutLimitInMinutes = 5.0d;
-            private static readonly int _leasingProcessPollingIntervalSeconds = 1;
+            private static readonly float _leasingProcessPollingIntervalSeconds = 1.0f;
+            private static readonly int _leasingProcessPollingRetryLimit = 5;
 
             private class LootLockerRemoteSessionProcess
             {
@@ -176,6 +177,7 @@ private class LootLockerRemoteSessionProcess
                 public LootLockerRemoteSessionLeaseStatus LastUpdatedStatus;
                 public DateTime LeasingProcessTimeoutTime;
                 public DateTime LastUpdatedAt;
+                public int Retries = 0;
                 public bool ShouldCancel;
                 public Action<LootLockerRemoteSessionStatusPollingResponse> UpdateCallbackAction;
                 public Action<LootLockerStartRemoteSessionResponse> ProcessCompletedCallbackAction;
@@ -238,8 +240,16 @@ protected IEnumerator ContinualPollingAction(Guid processGuid)
                         yield break;
                     }
 
-                    if (!startSessionResponse.success) //TODO: auto recover on 500s
+                    if (!startSessionResponse.success)
                     {
+                        if (startSessionResponse.statusCode >= 500 && startSessionResponse.statusCode <= 599 && processAfterStatusCheck.Retries <= _leasingProcessPollingRetryLimit)
+                        {
+                            // Recoverable error
+                            processAfterStatusCheck.Retries++;
+                            yield return new WaitForSeconds(_leasingProcessPollingIntervalSeconds);
+                            continue;
+                        }
+
                         startSessionResponse.lease_status = LootLockerRemoteSessionLeaseStatus.Failed;
                         processAfterStatusCheck.ProcessCompletedCallbackAction?.Invoke(startSessionResponse);
                         RemoveRemoteSessionProcess(processGuid);