-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Labels
Description
First of all, thank you for creating this excellent Looker extension! We're excited to use it in our analytics workflow.
Issue Description
The current deployment steps in the README have an illogical order that could
confuse users during setup. This is a simple documentation fix that requires
only reordering the existing steps without any code changes.
Current Order (Steps 1-4)
- Create Artifact Registry repository
- Authenticate with gcloud
- Navigate to directory (
cd dashboard-summarization/restful-service/src
) - Build and submit Docker image
Proposed Logical Order
- Navigate to directory (
cd dashboard-summarization/restful-service/src
) - Create Artifact Registry repository
- Authenticate with gcloud
- Build and submit Docker image
Reasoning
- Step 1 (Directory navigation) should be first because the Docker build
command requirescloudbuild.yaml
andDockerfile
to be present in the current
directory - Without being in the correct directory, the build command will fail
- The current order puts directory navigation as step 3, which is after creating
resources that the build depends on
Impact
- Users following the current order might experience confusion
- Makes the setup process less intuitive
- No functional impact, but improves user experience
Scope
This is a minor documentation improvement that:
- ✅ Requires no code changes
- ✅ Only involves reordering existing instructions
- ✅ Maintains all existing content
- ✅ Improves user experience
Would you like me to submit a PR to fix this ordering issue?