Improve Random use (#112)

* Improve Random use

* Fix style

* Fix analysis on fork

Author: loicgreffier

.github/workflows/pull_request.yml

@@ -52,6 +52,7 @@ jobs:
           report_paths: '**/target/surefire-reports/TEST-*.xml'
 
       - name: Sonar
+        if: github.event.pull_request.head.repo.fork == false
         run: mvn verify sonar:sonar
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

kafka-producer-quickstarts/kafka-producer-avro-generic/src/main/java/io/github/loicgreffier/producer/avro/generic/app/ProducerRunner.java

@@ -44,6 +44,7 @@
 @Slf4j
 @Component
 public class ProducerRunner {
+    private Random random = new Random();
     private final Producer<String, GenericRecord> producer;
 
     /**
@@ -118,8 +119,8 @@ public Future<RecordMetadata> send(ProducerRecord<String, GenericRecord> message
     private GenericRecord buildGenericRecord(Schema schema, int id) {
         GenericRecord genericRecord = new GenericData.Record(schema);
         genericRecord.put("id", (long) id);
-        genericRecord.put("firstName", FIRST_NAMES[new Random().nextInt(FIRST_NAMES.length)]);
-        genericRecord.put("lastName", LAST_NAMES[new Random().nextInt(LAST_NAMES.length)]);
+        genericRecord.put("firstName", FIRST_NAMES[random.nextInt(FIRST_NAMES.length)]);
+        genericRecord.put("lastName", LAST_NAMES[random.nextInt(LAST_NAMES.length)]);
         genericRecord.put("birthDate", System.currentTimeMillis());
         return genericRecord;
     }

kafka-producer-quickstarts/kafka-producer-avro-specific/src/main/java/io/github/loicgreffier/producer/avro/specific/app/ProducerRunner.java

@@ -40,6 +40,7 @@
 @Slf4j
 @Component
 public class ProducerRunner {
+    private Random random = new Random();
     private final Producer<String, KafkaUser> producer;
 
     /**
@@ -108,8 +109,8 @@ public Future<RecordMetadata> send(ProducerRecord<String, KafkaUser> message) {
     private KafkaUser buildKafkaUser(int id) {
         return KafkaUser.newBuilder()
                 .setId((long) id)
-                .setFirstName(FIRST_NAMES[new Random().nextInt(FIRST_NAMES.length)])
-                .setLastName(LAST_NAMES[new Random().nextInt(LAST_NAMES.length)])
+                .setFirstName(FIRST_NAMES[random.nextInt(FIRST_NAMES.length)])
+                .setLastName(LAST_NAMES[random.nextInt(LAST_NAMES.length)])
                 .setBirthDate(Instant.now())
                 .build();
     }

kafka-streams-quickstarts/specific-producers/kafka-streams-producer-user/src/main/java/io/github/loicgreffier/streams/producer/user/app/ProducerRunner.java

@@ -40,6 +40,7 @@
 @Slf4j
 @Component
 public class ProducerRunner {
+    private Random random = new Random();
     private final Producer<String, KafkaUser> producer;
 
     /**
@@ -111,13 +112,12 @@ public void send(ProducerRecord<String, KafkaUser> message) {
     private KafkaUser buildKafkaUser(int id) {
         return KafkaUser.newBuilder()
                 .setId((long) id)
-                .setFirstName(FIRST_NAMES[new Random().nextInt(FIRST_NAMES.length)])
-                .setLastName(LAST_NAMES[new Random().nextInt(LAST_NAMES.length)])
-                .setNationality(CountryCode.values()[new Random().nextInt(CountryCode.values().length)])
-                .setBirthDate(Instant.ofEpochSecond(new Random()
-                        .nextLong(
-                                Instant.parse("1924-01-01T00:00:00Z").getEpochSecond(),
-                                Instant.now().getEpochSecond())))
+                .setFirstName(FIRST_NAMES[random.nextInt(FIRST_NAMES.length)])
+                .setLastName(LAST_NAMES[random.nextInt(LAST_NAMES.length)])
+                .setNationality(CountryCode.values()[random.nextInt(CountryCode.values().length)])
+                .setBirthDate(Instant.ofEpochSecond(random.nextLong(
+                        Instant.parse("1924-01-01T00:00:00Z").getEpochSecond(),
+                        Instant.now().getEpochSecond())))
                 .build();
     }
 }