Skip to content

feature request: psr support #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardik-choudhary opened this issue Dec 10, 2024 · 1 comment
Open

feature request: psr support #14

hardik-choudhary opened this issue Dec 10, 2024 · 1 comment
Assignees

Comments

@hardik-choudhary
Copy link

I have a doubt and just wanted to share, as this SDK uses 'phpfastcache' for cache, why not psr6 or psr16

What problem did you meet?

I think using a specific package would just add an extra package and configuration to the project if someone using Symfony/Laravel etc...

And same for using superglobals for accessing query params in functions like 'handleSignInCallback', why not use psr 'ServerRequestInterface' or get the params as parameters

Describe what you'd like Logto to have

Suggestion: why not use standards

@darcyYe
Copy link
Contributor

darcyYe commented Dec 11, 2024

Thank you for your suggestion. We will gradually update and upgrade.
I'm curious if the current implementation is blocking you from using it? If you are in urgent need, we welcome contributions since our update may not meet your timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants