Skip to content

Commit a146788

Browse files
authored
fix(experience): replace global loading layer (#7348)
replace the global loading layer in the direct sign-in landing page
1 parent 52efea0 commit a146788

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

packages/experience/src/components/LoadingLayer/index.tsx

+7-3
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,15 @@ import styles from './index.module.scss';
55

66
export { default as LoadingIcon } from './LoadingIcon';
77

8+
export const LoadingIconWithContainer = () => (
9+
<div className={styles.container}>
10+
<LoadingIcon />
11+
</div>
12+
);
13+
814
const LoadingLayer = () => (
915
<LoadingMask>
10-
<div className={styles.container}>
11-
<LoadingIcon />
12-
</div>
16+
<LoadingIconWithContainer />
1317
</LoadingMask>
1418
);
1519

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
@use '@/scss/underscore' as _;
2+
3+
.container {
4+
position: fixed;
5+
inset: 0;
6+
@include _.flex-column;
7+
}

packages/experience/src/pages/DirectSignIn/index.tsx

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
import { useEffect } from 'react';
22
import { useParams } from 'react-router-dom';
33

4-
import LoadingLayer from '@/components/LoadingLayer';
4+
import { LoadingIconWithContainer } from '@/components/LoadingLayer';
55
import useSocial from '@/containers/SocialSignInList/use-social';
66
import useFallbackRoute from '@/hooks/use-fallback-route';
77
import { useSieMethods } from '@/hooks/use-sie';
88
import useSingleSignOn from '@/hooks/use-single-sign-on';
99

10+
import styles from './index.module.scss';
11+
1012
const DirectSignIn = () => {
1113
const { method, target } = useParams();
1214
const { socialConnectors, ssoConnectors } = useSieMethods();
@@ -35,6 +37,10 @@ const DirectSignIn = () => {
3537
window.location.replace('/' + fallback);
3638
}, [fallback, invokeSocialSignIn, invokeSso, method, socialConnectors, ssoConnectors, target]);
3739

38-
return <LoadingLayer />;
40+
return (
41+
<div className={styles.container}>
42+
<LoadingIconWithContainer />
43+
</div>
44+
);
3945
};
4046
export default DirectSignIn;

0 commit comments

Comments
 (0)