chore: update comments, notice that identifiers MUST work with first_screen

darcyYe · darcyYe · commit 17e2f9fe3fe8 · 2024-11-13T12:03:03.000+08:00
diff --git a/samples/sample-blazor/Program.cs b/samples/sample-blazor/Program.cs
@@ -54,7 +54,7 @@
 
         // Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.
         authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);
-        // Set the identifiers, should work with `first_screen`.
+        // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
         authProperties.SetParameter("identifiers", string.Join(",", new[] 
         {
             LogtoParameters.Authentication.Identifiers.Username,
diff --git a/samples/sample-mvc/Controllers/HomeController.cs b/samples/sample-mvc/Controllers/HomeController.cs
@@ -33,7 +33,7 @@ public IActionResult SignIn()
 
         // Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.
         authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);
-        // Set the identifiers, should work with `first_screen`.
+        // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
         authProperties.SetParameter("identifiers", string.Join(",", new[] 
         { 
             LogtoParameters.Authentication.Identifiers.Username,
diff --git a/samples/sample/Pages/Index.cshtml.cs b/samples/sample/Pages/Index.cshtml.cs
@@ -30,7 +30,7 @@ public async Task OnPostSignInAsync()
 
         // Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.
         authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);
-        // Set the identifiers, should work with `first_screen`.
+        // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
         authProperties.SetParameter("identifiers", string.Join(",", new[] 
         { 
             LogtoParameters.Authentication.Identifiers.Username,

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@`
`54`	`54`
`55`	`55`	`// Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.`
`56`	`56`	`authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);`
`57`		- // Set the identifiers, should work with `first_screen`.
	`57`	+ // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
`58`	`58`	`authProperties.SetParameter("identifiers", string.Join(",", new[]`
`59`	`59`	`{`
`60`	`60`	`LogtoParameters.Authentication.Identifiers.Username,`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public IActionResult SignIn()`
`33`	`33`
`34`	`34`	`// Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.`
`35`	`35`	`authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);`
`36`		- // Set the identifiers, should work with `first_screen`.
	`36`	+ // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
`37`	`37`	`authProperties.SetParameter("identifiers", string.Join(",", new[]`
`38`	`38`	`{`
`39`	`39`	`LogtoParameters.Authentication.Identifiers.Username,`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public async Task OnPostSignInAsync()`
`30`	`30`
`31`	`31`	`// Set the first screen, see https://docs.logto.io/docs/references/openid-connect/authentication-parameters/#first-screen.`
`32`	`32`	`authProperties.SetParameter("first_screen", LogtoParameters.Authentication.FirstScreen.Register);`
`33`		- // Set the identifiers, should work with `first_screen`.
	`33`	+ // Set the `identifiers`, this parameter MUST be used together with `first_screen`.
`34`	`34`	`authProperties.SetParameter("identifiers", string.Join(",", new[]`
`35`	`35`	`{`
`36`	`36`	`LogtoParameters.Authentication.Identifiers.Username,`