fix: vCluster upgrade 0.19.x to 0.25 (#2832) (#2840)

Upgrading vCluster was failing as the secret with the vCluster config yaml doesn't exist in vCluster versions prior to 0.20


(cherry picked from commit 49b7521)

Co-authored-by: Jose Silva <jaferson123@gmail.com>
Co-authored-by: José Silva <josesilva@Joses-MacBook-Pro.local>

Author: 3 people

pkg/cli/create_helm.go

@@ -326,7 +326,7 @@ func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.
 	verb := "created"
 	if isVClusterDeployed(release) {
 		verb = "upgraded"
-		currentVClusterConfig, err = getConfigfileFromSecret(ctx, vClusterName, cmd.Namespace)
+		currentVClusterConfig, err = getConfigfileFromSecret(ctx, vClusterName, cmd.Namespace, cmd.log)
 		if err != nil {
 			return err
 		}
@@ -935,7 +935,7 @@ func (cmd *createHelm) getVClusterConfigFromSnapshot(ctx context.Context) (strin
 	return "", nil
 }
 
-func getConfigfileFromSecret(ctx context.Context, name, namespace string) (*config.Config, error) {
+func getConfigfileFromSecret(ctx context.Context, name, namespace string, log log.Logger) (*config.Config, error) {
 	secretName := "vc-config-" + name
 
 	kConf := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(clientcmd.NewDefaultClientConfigLoadingRules(), &clientcmd.ConfigOverrides{})
@@ -951,6 +951,10 @@ func getConfigfileFromSecret(ctx context.Context, name, namespace string) (*conf
 
 	secret, err := clientset.CoreV1().Secrets(namespace).Get(ctx, secretName, metav1.GetOptions{})
 	if err != nil {
+		if kerrors.IsNotFound(err) {
+			log.Warnf("Secret %s not found, returning empty vCluster config", secretName)
+			return &config.Config{}, nil
+		}
 		return nil, err
 	}