Skip to content

Commit 6300f67

Browse files
authored
fix(android): fix footer position bug (#48)
* fix: footer position bug * chore: bump example
1 parent a1ee889 commit 6300f67

File tree

4 files changed

+68
-40
lines changed

4 files changed

+68
-40
lines changed

android/src/main/java/com/lodev09/truesheet/TrueSheetView.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,6 @@ class TrueSheetView(context: Context) :
103103
eventDispatcher?.dispatchEvent(DismissEvent(surfaceId, id))
104104
}
105105

106-
// Configure when showing and size changed
107-
setOnSizeChangeListener(object : RootSheetView.OnSizeChangeListener {
108-
override fun onSizeChange(width: Int, height: Int) {
109-
maxScreenHeight = height
110-
}
111-
})
112-
113106
// Configure sheet behavior events
114107
behavior.addBottomSheetCallback(
115108
object : BottomSheetBehavior.BottomSheetCallback() {

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"build:ios": "cd ios && xcodebuild -workspace TrueSheetExample.xcworkspace -scheme TrueSheetExample -configuration Debug -sdk iphonesimulator CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ GCC_OPTIMIZATION_LEVEL=0 GCC_PRECOMPILE_PREFIX_HEADER=YES ASSETCATALOG_COMPILER_OPTIMIZATION=time DEBUG_INFORMATION_FORMAT=dwarf COMPILER_INDEX_STORE_ENABLE=NO"
1414
},
1515
"dependencies": {
16-
"expo": "~51.0.14",
16+
"expo": "~51.0.17",
1717
"expo-build-properties": "~0.12.3",
1818
"react": "18.2.0",
1919
"react-native": "0.74.2",

example/src/sheets/ScrollViewSheet.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const ScrollViewSheet = forwardRef((props: ScrollViewSheetProps, ref: Ref
1313
return (
1414
<TrueSheet
1515
ref={ref}
16+
sizes={['80%']}
1617
scrollRef={scrollViewRef}
1718
onDismiss={() => console.log('Sheet ScrollView dismissed!')}
1819
onPresent={() => console.log(`Sheet ScrollView presented!`)}

yarn.lock

Lines changed: 66 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2821,9 +2821,9 @@ __metadata:
28212821
languageName: node
28222822
linkType: hard
28232823

2824-
"@expo/cli@npm:0.18.19":
2825-
version: 0.18.19
2826-
resolution: "@expo/cli@npm:0.18.19"
2824+
"@expo/cli@npm:0.18.21":
2825+
version: 0.18.21
2826+
resolution: "@expo/cli@npm:0.18.21"
28272827
dependencies:
28282828
"@babel/runtime": "npm:^7.20.0"
28292829
"@expo/code-signing-certificates": "npm:0.0.5"
@@ -2904,7 +2904,7 @@ __metadata:
29042904
ws: "npm:^8.12.1"
29052905
bin:
29062906
expo-internal: build/bin/cli
2907-
checksum: 10c0/1fc0e44a3d374b001cd90dabc49de0924e9059dfae8dec0be94cb3907e82e1d9fd3441846a4fa9a34c2fde166a8af237b97687fab572820cd2dc7842d732a89b
2907+
checksum: 10c0/698515a04da5830800a1e18c130dcea2be1ec25efa318a79a8dc89d0d8e66eaa2598fffc7288928b53e36f5e4c19c0f161770c2e47da88303d17cc69d6d6a1e9
29082908
languageName: node
29092909
linkType: hard
29102910

@@ -2918,9 +2918,9 @@ __metadata:
29182918
languageName: node
29192919
linkType: hard
29202920

2921-
"@expo/config-plugins@npm:8.0.5":
2922-
version: 8.0.5
2923-
resolution: "@expo/config-plugins@npm:8.0.5"
2921+
"@expo/config-plugins@npm:8.0.6":
2922+
version: 8.0.6
2923+
resolution: "@expo/config-plugins@npm:8.0.6"
29242924
dependencies:
29252925
"@expo/config-types": "npm:^51.0.0-unreleased"
29262926
"@expo/json-file": "npm:~8.3.0"
@@ -2937,7 +2937,7 @@ __metadata:
29372937
slugify: "npm:^1.6.6"
29382938
xcode: "npm:^3.0.1"
29392939
xml2js: "npm:0.6.0"
2940-
checksum: 10c0/9025bb8932368c71dc6a33a376c07c59f821b44cd1e188e48ac647b28a48c54b42e7f1ad186ac5b76faa4879c019c6888ae122aa49401d5f7214f90b5eeb631a
2940+
checksum: 10c0/4d4be4f7c9b791ef1a97c54e369219c08df2cd9a4f06604a54e927e1129e83912762339d198886febd82d045af3bf060eb197e1930fd0879a4ad90c9d3b555e6
29412941
languageName: node
29422942
linkType: hard
29432943

@@ -3053,7 +3053,33 @@ __metadata:
30533053
languageName: node
30543054
linkType: hard
30553055

3056-
"@expo/metro-config@npm:0.18.7, @expo/metro-config@npm:~0.18.6":
3056+
"@expo/metro-config@npm:0.18.8":
3057+
version: 0.18.8
3058+
resolution: "@expo/metro-config@npm:0.18.8"
3059+
dependencies:
3060+
"@babel/core": "npm:^7.20.0"
3061+
"@babel/generator": "npm:^7.20.5"
3062+
"@babel/parser": "npm:^7.20.0"
3063+
"@babel/types": "npm:^7.20.0"
3064+
"@expo/config": "npm:~9.0.0-beta.0"
3065+
"@expo/env": "npm:~0.3.0"
3066+
"@expo/json-file": "npm:~8.3.0"
3067+
"@expo/spawn-async": "npm:^1.7.2"
3068+
chalk: "npm:^4.1.0"
3069+
debug: "npm:^4.3.2"
3070+
find-yarn-workspace-root: "npm:~2.0.0"
3071+
fs-extra: "npm:^9.1.0"
3072+
getenv: "npm:^1.0.0"
3073+
glob: "npm:^7.2.3"
3074+
jsc-safe-url: "npm:^0.2.4"
3075+
lightningcss: "npm:~1.19.0"
3076+
postcss: "npm:~8.4.32"
3077+
resolve-from: "npm:^5.0.0"
3078+
checksum: 10c0/507aba80bcff43fd37ddd05d2535da8e6a247502a12b53dc3505e45a0ee9f4561e06f268a81b45813254fc60d511a6c2176361f288813851c6506c6098aeccea
3079+
languageName: node
3080+
linkType: hard
3081+
3082+
"@expo/metro-config@npm:~0.18.6":
30573083
version: 0.18.7
30583084
resolution: "@expo/metro-config@npm:0.18.7"
30593085
dependencies:
@@ -6881,6 +6907,13 @@ __metadata:
68816907
languageName: node
68826908
linkType: hard
68836909

6910+
"babel-plugin-react-compiler@npm:^0.0.0-experimental-592953e-20240517":
6911+
version: 0.0.0
6912+
resolution: "babel-plugin-react-compiler@npm:0.0.0"
6913+
checksum: 10c0/b7db0bd49dfe28ea8945a72e90a21f1ab8a14e5ed6987a4f8780bbf15e68bb742aa0be45c019084390623a73c39c44dd57964cc71a01093f4f929c09eb5e5e50
6914+
languageName: node
6915+
linkType: hard
6916+
68846917
"babel-plugin-react-native-web@npm:~0.19.10":
68856918
version: 0.19.11
68866919
resolution: "babel-plugin-react-native-web@npm:0.19.11"
@@ -6919,9 +6952,9 @@ __metadata:
69196952
languageName: node
69206953
linkType: hard
69216954

6922-
"babel-preset-expo@npm:~11.0.10":
6923-
version: 11.0.10
6924-
resolution: "babel-preset-expo@npm:11.0.10"
6955+
"babel-preset-expo@npm:~11.0.11":
6956+
version: 11.0.11
6957+
resolution: "babel-preset-expo@npm:11.0.11"
69256958
dependencies:
69266959
"@babel/plugin-proposal-decorators": "npm:^7.12.9"
69276960
"@babel/plugin-transform-export-namespace-from": "npm:^7.22.11"
@@ -6930,9 +6963,10 @@ __metadata:
69306963
"@babel/preset-react": "npm:^7.22.15"
69316964
"@babel/preset-typescript": "npm:^7.23.0"
69326965
"@react-native/babel-preset": "npm:0.74.84"
6966+
babel-plugin-react-compiler: "npm:^0.0.0-experimental-592953e-20240517"
69336967
babel-plugin-react-native-web: "npm:~0.19.10"
69346968
react-refresh: "npm:^0.14.2"
6935-
checksum: 10c0/61e4332afe74f0b77c4ec43956557103eaf0526f79de6eeeafe36e62e9697a3b460cb46be5504d77aef4e105b500fa8028f1d60b126fbddaa1b3e12c879a980d
6969+
checksum: 10c0/059c9f2e38251276c28de70b46d8adfb182d8372814c1540d6d6b057328410838fb43cae8463f8e02eefe8647018eca0d7536512713d2d09e83d48cd5b639235
69366970
languageName: node
69376971
linkType: hard
69386972

@@ -10331,16 +10365,16 @@ __metadata:
1033110365
languageName: node
1033210366
linkType: hard
1033310367

10334-
"expo-asset@npm:~10.0.9":
10335-
version: 10.0.9
10336-
resolution: "expo-asset@npm:10.0.9"
10368+
"expo-asset@npm:~10.0.10":
10369+
version: 10.0.10
10370+
resolution: "expo-asset@npm:10.0.10"
1033710371
dependencies:
1033810372
expo-constants: "npm:~16.0.0"
1033910373
invariant: "npm:^2.2.4"
1034010374
md5-file: "npm:^3.2.3"
1034110375
peerDependencies:
1034210376
expo: "*"
10343-
checksum: 10c0/6dea9bd2de2f5219651998cfb93106c69f6cc8296eda7d48760f61029579680bc74f70676a177214ba195dbbd96d00c6c231c4df1cde729e441e22ff5b829a28
10377+
checksum: 10c0/aed3164cee4483e47fa56c8898384769d60ebb3f94553f7ad2a33a8902d73a1379aee3fc51833c8f0a4a59979ed842ba079e52c8e1903104b1ad312ad90fe1d1
1034410378
languageName: node
1034510379
linkType: hard
1034610380

@@ -10411,37 +10445,37 @@ __metadata:
1041110445
languageName: node
1041210446
linkType: hard
1041310447

10414-
"expo-modules-core@npm:1.12.15":
10415-
version: 1.12.15
10416-
resolution: "expo-modules-core@npm:1.12.15"
10448+
"expo-modules-core@npm:1.12.18":
10449+
version: 1.12.18
10450+
resolution: "expo-modules-core@npm:1.12.18"
1041710451
dependencies:
1041810452
invariant: "npm:^2.2.4"
10419-
checksum: 10c0/a68212b6308f781ac2a91b3129131356b006a14030149919ff29acc33cfbee9765a24e6f1ec11d18a7d7ca7d41d4599732a81e33259b3e83f27ce9e0c11776fa
10453+
checksum: 10c0/924d55d660d0f0ea40363b317c4eea7b67be6e0dfa8befd35395ec33502277a4c0ca34bb7701793bda14ba744f648708e9f896d6fa653c546d66fbaaae04a7e9
1042010454
languageName: node
1042110455
linkType: hard
1042210456

10423-
"expo@npm:~51.0.14":
10424-
version: 51.0.14
10425-
resolution: "expo@npm:51.0.14"
10457+
"expo@npm:~51.0.17":
10458+
version: 51.0.17
10459+
resolution: "expo@npm:51.0.17"
1042610460
dependencies:
1042710461
"@babel/runtime": "npm:^7.20.0"
10428-
"@expo/cli": "npm:0.18.19"
10462+
"@expo/cli": "npm:0.18.21"
1042910463
"@expo/config": "npm:9.0.1"
10430-
"@expo/config-plugins": "npm:8.0.5"
10431-
"@expo/metro-config": "npm:0.18.7"
10464+
"@expo/config-plugins": "npm:8.0.6"
10465+
"@expo/metro-config": "npm:0.18.8"
1043210466
"@expo/vector-icons": "npm:^14.0.0"
10433-
babel-preset-expo: "npm:~11.0.10"
10434-
expo-asset: "npm:~10.0.9"
10467+
babel-preset-expo: "npm:~11.0.11"
10468+
expo-asset: "npm:~10.0.10"
1043510469
expo-file-system: "npm:~17.0.1"
1043610470
expo-font: "npm:~12.0.7"
1043710471
expo-keep-awake: "npm:~13.0.2"
1043810472
expo-modules-autolinking: "npm:1.11.1"
10439-
expo-modules-core: "npm:1.12.15"
10473+
expo-modules-core: "npm:1.12.18"
1044010474
fbemitter: "npm:^3.0.0"
1044110475
whatwg-url-without-unicode: "npm:8.0.0-3"
1044210476
bin:
1044310477
expo: bin/cli
10444-
checksum: 10c0/96828439b473f7b29c0f9876bf135b229a6f4c4aac26d9dd446033750c225b8883b6857561d04f292dd8b5c4582762e67a8e2dbf55bb50613f825025394b997a
10478+
checksum: 10c0/538cdb06bf62775611288976cc43b234accf5dd53df023591781fa030365dd114504213bfe7cf8d056adfcc9a34a4a60f904208f45196fd37c7f7a3f73b391d6
1044510479
languageName: node
1044610480
linkType: hard
1044710481

@@ -20743,7 +20777,7 @@ __metadata:
2074320777
"@react-native/babel-preset": "npm:0.74.83"
2074420778
"@react-native/metro-config": "npm:0.74.83"
2074520779
babel-plugin-module-resolver: "npm:^5.0.0"
20746-
expo: "npm:~51.0.14"
20780+
expo: "npm:~51.0.17"
2074720781
expo-build-properties: "npm:~0.12.3"
2074820782
react: "npm:18.2.0"
2074920783
react-native: "npm:0.74.2"

0 commit comments

Comments
 (0)