-
-
Notifications
You must be signed in to change notification settings - Fork 83
Review numpy API coverage #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#262 here is the diff for |
Ok, it's coming back to me. https://github.com/lmfit/uncertainties/pull/262/files#diff-3920e6d42d819e305be2c6e3cb5318e2bb0e7c35f62e5b25e92bd41726a869f1R165 There is a comment on this line. The way the code is now does not fully support numpy matrices. It partially supports them. Getting back support at the level of I vote for |
I think it is good to drop matrix support (and internal usage) since numpy deprecated it. It would be nice to keep a convenience function for inverting a square array with uncertainty propagation. I think that is all we were getting from the matrix class (besides * acting as matrix multiplication which is not so important since @ was added as a dedicated symbol for that). |
Yes, the code I have now for |
Since Uncertainties has not been updated much recently, there has been time for the functions in the unumpy module to drift relative to upstream numpy. Following on from the need to look at the numpy support because of numpy 2 (#222), it would be good to review the current unumpy interface to make sure the current functions still match numpy's versions (no change in function signature) and no functions added to numpy that a user would expect are missing. Besides that there are a couple known action items:
acos
forarccos
. It would be good for unumpy to include similar aliases.unumpy.matrix
could be updated/deprecated. The corresponding numpy.matrix has been documented as not recommended and possibly to be removed for a long time now. However, the numpy developers did not take the opportunity to remove it with numpy 2.0 and likely numpy 3.0 will not happen for a long time. Still,unumpy.matrix
could perhaps migrate to deriving from a standard array instead ofnumpy.matrix
.The text was updated successfully, but these errors were encountered: