Skip to content

Update compareFloat16ULP to align with DXC's implementation #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kmpeng opened this issue May 21, 2025 · 0 comments · Fixed by #207
Closed

Update compareFloat16ULP to align with DXC's implementation #202

kmpeng opened this issue May 21, 2025 · 0 comments · Fixed by #207
Assignees
@spall

Comments

@kmpeng
Copy link
Contributor

kmpeng commented May 21, 2025

ULP comparison support for Float16 was recently added based on the existing pattern in DXC's compareHalfULP function (see issue #81). There will likely be changes to the DXC implementation via PR #7393, which we should also update in our compareFloat16ULP implementation to maintain consistency with DXC.

Changes:

  1. Handling +0 and -0 as equal
  2. ULP differences are calculated with a monotonic ordering
inbelic pushed a commit to inbelic/offload-test-suite that referenced this issue May 23, 2025
@hekota
Test for GetDimensions method on structured buffers (llvm#64)
3138e85 
Tests GetDimensions method on StructuredBuffer, RWStructuredBuffer,
AppendStructuredBuffer and ConsumeStructuredBuffer.

Test for RasterizerOrderedStructuredBuffer will need to be added later after
the offload-test-suite adds support for pixel shaders.

Closes llvm#202
@spall spall self-assigned this May 27, 2025
@spall spall mentioned this issue May 27, 2025
Merged
@spall spall moved this to Active in HLSL Support May 28, 2025
@github-project-automation github-project-automation bot moved this from Active to Closed in HLSL Support May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spall spall

Labels
None yet
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ULP comparison support for Float16 to reflect changes in DXC spall/offload-test-suite
2 participants
@spall @kmpeng