Skip to content

Commit e7c3dc5

Browse files
[CI] Migrate all windows node pools to pd-ssd (#457)
This migrates the other windows node pool in us-central1-a to pd-ssd boot disks as well. We saw some small performance improvements from doing this (~5%). Less than expected, but significant enough to ship.
1 parent 489511a commit e7c3dc5

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

premerge/gke_cluster/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ resource "google_container_node_pool" "llvm_premerge_windows" {
9696
"disable-legacy-endpoints" = "true"
9797
}
9898
disk_size_gb = 200
99-
disk_type = var.windows_disk_type
99+
disk_type = "pd-ssd"
100100
# Terraform wants to recreate the node pool everytime whe running
101101
# terraform apply unless we explicitly set this.
102102
# TODO(boomanaiden154): Look into why terraform is doing this so we do

premerge/gke_cluster/variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,3 @@ variable "service_node_pool_locations" {
2323
type = list(any)
2424
default = null
2525
}
26-
27-
variable "windows_disk_type" {
28-
description = "The GCP disk type to use for the windows node boot disks"
29-
type = string
30-
default = "pd-balanced"
31-
}

premerge/main.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ module "premerge_cluster_us_west" {
6262
linux_machine_type = "n2d-standard-64"
6363
windows_machine_type = "n2d-standard-32"
6464
service_node_pool_locations = ["us-west1-a"]
65-
# TODO(boomanaiden154): Remove this once the experiment is over, either
66-
# reverting to how everything was before or making this the default within
67-
# the gke_cluster module.
68-
windows_disk_type = "pd-ssd"
6965
}
7066

7167
provider "helm" {

0 commit comments

Comments
 (0)