From 0ba04ff52d6238a2773941b0b4306a3c3c236877 Mon Sep 17 00:00:00 2001 From: abhishek-kaushik22 Date: Sun, 6 Apr 2025 16:40:03 +0530 Subject: [PATCH] [NFC] Use `std::move` to avoid copy --- llvm/include/llvm/CodeGen/SelectionDAGNodes.h | 4 ++-- llvm/lib/Target/X86/X86ISelLowering.cpp | 2 +- llvm/utils/TableGen/SubtargetEmitter.cpp | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h index 2283f99202e2f..38b4ba89e26e6 100644 --- a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h +++ b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h @@ -3296,8 +3296,8 @@ namespace ISD { std::function Match, bool AllowUndefs = false, bool AllowTruncation = false) { - return matchUnaryPredicateImpl(Op, Match, AllowUndefs, - AllowTruncation); + return matchUnaryPredicateImpl( + Op, std::move(Match), AllowUndefs, AllowTruncation); } /// Hook for matching ConstantFPSDNode predicate diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 02398923ebc90..7bdb85f76be98 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -41005,7 +41005,7 @@ static SDValue combineX86ShufflesRecursively( resolveTargetShuffleFromZeroables(OpMask, OpUndef, OpZero, ResolveKnownZeros); - Mask = OpMask; + Mask = std::move(OpMask); Ops.append(OpInputs.begin(), OpInputs.end()); } else { resolveTargetShuffleFromZeroables(OpMask, OpUndef, OpZero); diff --git a/llvm/utils/TableGen/SubtargetEmitter.cpp b/llvm/utils/TableGen/SubtargetEmitter.cpp index c398b6f9bf7cd..aa5e56e15859b 100644 --- a/llvm/utils/TableGen/SubtargetEmitter.cpp +++ b/llvm/utils/TableGen/SubtargetEmitter.cpp @@ -1054,7 +1054,8 @@ void SubtargetEmitter::expandProcResources( continue; ConstRecVec SuperResources = PR->getValueAsListOfDefs("Resources"); bool AllContained = - all_of(SubResources, [SuperResources](const Record *SubResource) { + all_of(SubResources, [SuperResources = std::move(SuperResources)]( + const Record *SubResource) { return is_contained(SuperResources, SubResource); }); if (AllContained) {