Skip to content

Commit fb1216e

Browse files
authored
[NFC][GlobalISel] Minor cleanup in LegalityQuery constructors (#126285)
- Remove a redundant LegalityQuery constructor by using a default value for `MMODescrs` and remove const for ArrayRef arguments. - Use a delegating constructor for `MemDesc` constructor that takes `MachineMemOperand`.
1 parent cea799a commit fb1216e

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,20 +119,17 @@ struct LegalityQuery {
119119
MemDesc(LLT MemoryTy, uint64_t AlignInBits, AtomicOrdering Ordering)
120120
: MemoryTy(MemoryTy), AlignInBits(AlignInBits), Ordering(Ordering) {}
121121
MemDesc(const MachineMemOperand &MMO)
122-
: MemoryTy(MMO.getMemoryType()),
123-
AlignInBits(MMO.getAlign().value() * 8),
124-
Ordering(MMO.getSuccessOrdering()) {}
122+
: MemDesc(MMO.getMemoryType(), MMO.getAlign().value() * 8,
123+
MMO.getSuccessOrdering()) {}
125124
};
126125

127126
/// Operations which require memory can use this to place requirements on the
128127
/// memory type for each MMO.
129128
ArrayRef<MemDesc> MMODescrs;
130129

131-
constexpr LegalityQuery(unsigned Opcode, const ArrayRef<LLT> Types,
132-
const ArrayRef<MemDesc> MMODescrs)
130+
constexpr LegalityQuery(unsigned Opcode, ArrayRef<LLT> Types,
131+
ArrayRef<MemDesc> MMODescrs = {})
133132
: Opcode(Opcode), Types(Types), MMODescrs(MMODescrs) {}
134-
constexpr LegalityQuery(unsigned Opcode, const ArrayRef<LLT> Types)
135-
: LegalityQuery(Opcode, Types, {}) {}
136133

137134
raw_ostream &print(raw_ostream &OS) const;
138135
};

0 commit comments

Comments
 (0)