Skip to content

Commit fa723ee

Browse files
committed
Update some comments
1 parent 9a70a29 commit fa723ee

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,7 @@ LowerCallResults(MachineInstr &CallResults, DebugLoc DL, MachineBasicBlock *BB,
844844

845845
if (IsIndirect) {
846846
// Placeholder for the type index.
847+
// This gets replaced with the correct value in WebAssemblyMCInstLower.cpp
847848
MIB.addImm(0);
848849
// The table into which this call_indirect indexes.
849850
MCSymbolWasm *Table = IsFuncrefCall

llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,6 @@ void WebAssemblyMCInstLower::lower(const MachineInstr *MI,
222222
// The return type needs special handling because it could be void.
223223
auto ReturnType = static_cast<WebAssembly::BlockType>(
224224
CImm.extractBitsAsZExtValue(64, (NumWords - 1) * 64));
225-
assert(ReturnType != WebAssembly::BlockType::Invalid);
226225
SmallVector<wasm::ValType, 2> Returns;
227226
switch (ReturnType) {
228227
case WebAssembly::BlockType::Invalid:
@@ -273,7 +272,7 @@ void WebAssemblyMCInstLower::lower(const MachineInstr *MI,
273272
if (DescIndex < Desc.NumOperands) {
274273
const MCOperandInfo &Info = Desc.operands()[DescIndex];
275274
// Replace type index placeholder with actual type index. The type index
276-
// placeholders are immedates or CImmediates and have an operand type of
275+
// placeholders are Immediates and have an operand type of
277276
// OPERAND_TYPEINDEX or OPERAND_SIGNATURE.
278277
if (Info.OperandType == WebAssembly::OPERAND_TYPEINDEX) {
279278
// Lower type index placeholder for a CALL_INDIRECT instruction

0 commit comments

Comments
 (0)