Skip to content

Commit dbbcfef

Browse files
committed
Revert "[CodeGen] Skip null physical register in AntiDepBreaker (NFCI)"
This reverts commit d41f6cf. The commit contained wrong phabricator link.
1 parent ad571e0 commit dbbcfef

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ void AggressiveAntiDepBreaker::Observe(MachineInstr &MI, unsigned Count,
200200
LLVM_DEBUG(dbgs() << "\tRegs:");
201201

202202
std::vector<unsigned> &DefIndices = State->GetDefIndices();
203-
for (unsigned Reg = 1; Reg != TRI->getNumRegs(); ++Reg) {
203+
for (unsigned Reg = 0; Reg != TRI->getNumRegs(); ++Reg) {
204204
// If Reg is current live, then mark that it can't be renamed as
205205
// we don't know the extent of its live-range anymore (now that it
206206
// has been scheduled). If it is not live but was defined in the
@@ -776,7 +776,7 @@ unsigned AggressiveAntiDepBreaker::BreakAntiDependencies(
776776
#ifndef NDEBUG
777777
LLVM_DEBUG(dbgs() << "\n===== Aggressive anti-dependency breaking\n");
778778
LLVM_DEBUG(dbgs() << "Available regs:");
779-
for (unsigned Reg = 1; Reg < TRI->getNumRegs(); ++Reg) {
779+
for (unsigned Reg = 0; Reg < TRI->getNumRegs(); ++Reg) {
780780
if (!State->IsLive(Reg))
781781
LLVM_DEBUG(dbgs() << " " << printReg(Reg, TRI));
782782
}

llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ CriticalAntiDepBreaker::~CriticalAntiDepBreaker() = default;
4949

5050
void CriticalAntiDepBreaker::StartBlock(MachineBasicBlock *BB) {
5151
const unsigned BBSize = BB->size();
52-
for (unsigned i = 1, e = TRI->getNumRegs(); i != e; ++i) {
52+
for (unsigned i = 0, e = TRI->getNumRegs(); i != e; ++i) {
5353
// Clear out the register class data.
5454
Classes[i] = nullptr;
5555

@@ -111,7 +111,7 @@ void CriticalAntiDepBreaker::Observe(MachineInstr &MI, unsigned Count,
111111
return;
112112
assert(Count < InsertPosIndex && "Instruction index out of expected range!");
113113

114-
for (unsigned Reg = 1; Reg != TRI->getNumRegs(); ++Reg) {
114+
for (unsigned Reg = 0; Reg != TRI->getNumRegs(); ++Reg) {
115115
if (KillIndices[Reg] != ~0u) {
116116
// If Reg is currently live, then mark that it can't be renamed as
117117
// we don't know the extent of its live-range anymore (now that it
@@ -265,7 +265,7 @@ void CriticalAntiDepBreaker::ScanInstruction(MachineInstr &MI, unsigned Count) {
265265
[&](MCPhysReg SR) { return MO.clobbersPhysReg(SR); });
266266
};
267267

268-
for (unsigned i = 1, e = TRI->getNumRegs(); i != e; ++i) {
268+
for (unsigned i = 0, e = TRI->getNumRegs(); i != e; ++i) {
269269
if (ClobbersPhysRegAndSubRegs(i)) {
270270
DefIndices[i] = Count;
271271
KillIndices[i] = ~0u;
@@ -463,7 +463,7 @@ BreakAntiDependencies(const std::vector<SUnit> &SUnits,
463463
LLVM_DEBUG(dbgs() << "Critical path has total latency "
464464
<< (Max->getDepth() + Max->Latency) << "\n");
465465
LLVM_DEBUG(dbgs() << "Available regs:");
466-
for (unsigned Reg = 1; Reg < TRI->getNumRegs(); ++Reg) {
466+
for (unsigned Reg = 0; Reg < TRI->getNumRegs(); ++Reg) {
467467
if (KillIndices[Reg] == ~0u)
468468
LLVM_DEBUG(dbgs() << " " << printReg(Reg, TRI));
469469
}

0 commit comments

Comments
 (0)