Skip to content

Commit c6776bb

Browse files
[PS5][Driver] Fix bad negative check in ps5-linker.c test case (#147484)
A regex used in a negative check had an unintended match with the pseudo-random part of the temporary directory created by a lit run on the SIE buildbot, causing a spurious test failure: https://lab.llvm.org/buildbot/#/builders/144/builds/29507 // CHECK-NO-CRT-NOT: crt{{[^"]*}}.o" ^ <stdin>:7:224: note: found here [...] "/tmp/lit-tmp-vcrtn3vi/ps5-linker-ee5f76.o" "-r" !~~~~~~~~~~~~~~~~~~~~~~~~~~~ The updated check avoids such accidental matches.
1 parent db7888c commit c6776bb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

clang/test/Driver/ps5-linker.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
// CHECK-SHARED-CRT-SAME: "-l:crtendS.o" "-l:crtn.o"
166166
// CHECK-STATIC-CRT-SAME: "-l:crtend.o" "-l:crtn.o"
167167

168-
// CHECK-NO-CRT-NOT: crt{{[^"]*}}.o"
168+
// CHECK-NO-CRT-NOT: "-l:crt
169169
// CHECK-NO-LIBS-NOT: "-l{{[^"]*}}"
170170

171171
// Test the driver's control over the -fcrash-diagnostics-dir behavior with linker flags.

0 commit comments

Comments
 (0)