Skip to content

Commit bccd34f

Browse files
authored
[SelectionDAG] Correctly Mark Required Analyses (#147649)
#147560 changed when the legacy SelectionDAG pass needs TargetTransformInfoWrapperPass to always require it (rather than only when assertions are enabled). `SelectionDAGISelLegacy::getAnalysisUsage` was not updated in that PR, which was causing crashes on assertions-disabled builds, which are hard to track down. This makes the required update, which should avoid crashes being seen on some buildbots and by some users.
1 parent 15e7753 commit bccd34f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,9 +396,7 @@ void SelectionDAGISelLegacy::getAnalysisUsage(AnalysisUsage &AU) const {
396396
AU.addRequired<StackProtector>();
397397
AU.addPreserved<GCModuleInfo>();
398398
AU.addRequired<TargetLibraryInfoWrapperPass>();
399-
#ifndef NDEBUG
400399
AU.addRequired<TargetTransformInfoWrapperPass>();
401-
#endif
402400
AU.addRequired<AssumptionCacheTracker>();
403401
if (UseMBPI && OptLevel != CodeGenOptLevel::None)
404402
AU.addRequired<BranchProbabilityInfoWrapperPass>();

0 commit comments

Comments
 (0)