Skip to content

Commit ad4a42b

Browse files
authored
[RISCV] Remove -riscv-split-regalloc flag (#89715)
Split vector and scalar regalloc has been enabled by default for 5 months now since d0a39e6, and shipped with 18.1.0. I haven't heard of any issues with it so far, so this proposes to remove the flag to reduce the number of configurations we have to support.
1 parent 806db47 commit ad4a42b

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

llvm/lib/Target/RISCV/RISCVTargetMachine.cpp

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ static cl::opt<bool>
9191
cl::desc("Enable the loop data prefetch pass"),
9292
cl::init(true));
9393

94-
static cl::opt<bool>
95-
EnableSplitRegAlloc("riscv-split-regalloc", cl::Hidden,
96-
cl::desc("Enable Split RegisterAlloc for RVV"),
97-
cl::init(true));
98-
9994
static cl::opt<bool> EnableMISchedLoadClustering(
10095
"riscv-misched-load-clustering", cl::Hidden,
10196
cl::desc("Enable load clustering in the machine scheduler"),
@@ -392,16 +387,13 @@ FunctionPass *RISCVPassConfig::createRVVRegAllocPass(bool Optimized) {
392387
}
393388

394389
bool RISCVPassConfig::addRegAssignAndRewriteFast() {
395-
if (EnableSplitRegAlloc)
396-
addPass(createRVVRegAllocPass(false));
390+
addPass(createRVVRegAllocPass(false));
397391
return TargetPassConfig::addRegAssignAndRewriteFast();
398392
}
399393

400394
bool RISCVPassConfig::addRegAssignAndRewriteOptimized() {
401-
if (EnableSplitRegAlloc) {
402-
addPass(createRVVRegAllocPass(true));
403-
addPass(createVirtRegRewriter(false));
404-
}
395+
addPass(createRVVRegAllocPass(true));
396+
addPass(createVirtRegRewriter(false));
405397
return TargetPassConfig::addRegAssignAndRewriteOptimized();
406398
}
407399

0 commit comments

Comments
 (0)