Skip to content

Commit 9b95d08

Browse files
[GISel] Make create.*InstructionSelector arguments const (#98243)
The InstructionSelector objects all take these arguments in as `const`. This function does not modify the object. Therefore we can mark them as `const` here.
1 parent 2ef4f86 commit 9b95d08

File tree

8 files changed

+21
-18
lines changed

8 files changed

+21
-18
lines changed

llvm/lib/Target/AArch64/AArch64.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ FunctionPass *createSMEABIPass();
6262
ModulePass *createSVEIntrinsicOptsPass();
6363
InstructionSelector *
6464
createAArch64InstructionSelector(const AArch64TargetMachine &,
65-
AArch64Subtarget &, AArch64RegisterBankInfo &);
65+
const AArch64Subtarget &,
66+
const AArch64RegisterBankInfo &);
6667
FunctionPass *createAArch64O0PreLegalizerCombiner();
6768
FunctionPass *createAArch64PreLegalizerCombiner();
6869
FunctionPass *createAArch64PostLegalizerCombiner(bool IsOptNone);

llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7790,8 +7790,8 @@ void AArch64InstructionSelector::processPHIs(MachineFunction &MF) {
77907790
namespace llvm {
77917791
InstructionSelector *
77927792
createAArch64InstructionSelector(const AArch64TargetMachine &TM,
7793-
AArch64Subtarget &Subtarget,
7794-
AArch64RegisterBankInfo &RBI) {
7793+
const AArch64Subtarget &Subtarget,
7794+
const AArch64RegisterBankInfo &RBI) {
77957795
return new AArch64InstructionSelector(TM, Subtarget, RBI);
77967796
}
77977797
}

llvm/lib/Target/Mips/Mips.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ FunctionPass *createMipsPreLegalizeCombiner();
4141
FunctionPass *createMipsPostLegalizeCombiner(bool IsOptNone);
4242
FunctionPass *createMipsMulMulBugPass();
4343

44-
InstructionSelector *createMipsInstructionSelector(const MipsTargetMachine &,
45-
MipsSubtarget &,
46-
MipsRegisterBankInfo &);
44+
InstructionSelector *
45+
createMipsInstructionSelector(const MipsTargetMachine &, const MipsSubtarget &,
46+
const MipsRegisterBankInfo &);
4747

4848
void initializeMicroMipsSizeReducePass(PassRegistry &);
4949
void initializeMipsBranchExpansionPass(PassRegistry &);

llvm/lib/Target/Mips/MipsInstructionSelector.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -927,9 +927,10 @@ bool MipsInstructionSelector::select(MachineInstr &I) {
927927
}
928928

929929
namespace llvm {
930-
InstructionSelector *createMipsInstructionSelector(const MipsTargetMachine &TM,
931-
MipsSubtarget &Subtarget,
932-
MipsRegisterBankInfo &RBI) {
930+
InstructionSelector *
931+
createMipsInstructionSelector(const MipsTargetMachine &TM,
932+
const MipsSubtarget &Subtarget,
933+
const MipsRegisterBankInfo &RBI) {
933934
return new MipsInstructionSelector(TM, Subtarget, RBI);
934935
}
935936
} // end namespace llvm

llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,8 +1330,8 @@ void RISCVInstructionSelector::emitFence(AtomicOrdering FenceOrdering,
13301330
namespace llvm {
13311331
InstructionSelector *
13321332
createRISCVInstructionSelector(const RISCVTargetMachine &TM,
1333-
RISCVSubtarget &Subtarget,
1334-
RISCVRegisterBankInfo &RBI) {
1333+
const RISCVSubtarget &Subtarget,
1334+
const RISCVRegisterBankInfo &RBI) {
13351335
return new RISCVInstructionSelector(TM, Subtarget, RBI);
13361336
}
13371337
} // end namespace llvm

llvm/lib/Target/RISCV/RISCV.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,10 @@ void initializeRISCVMoveMergePass(PassRegistry &);
7979
FunctionPass *createRISCVPushPopOptimizationPass();
8080
void initializeRISCVPushPopOptPass(PassRegistry &);
8181

82-
InstructionSelector *createRISCVInstructionSelector(const RISCVTargetMachine &,
83-
RISCVSubtarget &,
84-
RISCVRegisterBankInfo &);
82+
InstructionSelector *
83+
createRISCVInstructionSelector(const RISCVTargetMachine &,
84+
const RISCVSubtarget &,
85+
const RISCVRegisterBankInfo &);
8586
void initializeRISCVDAGToDAGISelLegacyPass(PassRegistry &);
8687

8788
FunctionPass *createRISCVPostLegalizerCombiner();

llvm/lib/Target/X86/GISel/X86InstructionSelector.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,7 +1871,7 @@ bool X86InstructionSelector::selectSelect(MachineInstr &I,
18711871

18721872
InstructionSelector *
18731873
llvm::createX86InstructionSelector(const X86TargetMachine &TM,
1874-
X86Subtarget &Subtarget,
1875-
X86RegisterBankInfo &RBI) {
1874+
const X86Subtarget &Subtarget,
1875+
const X86RegisterBankInfo &RBI) {
18761876
return new X86InstructionSelector(TM, Subtarget, RBI);
18771877
}

llvm/lib/Target/X86/X86.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ FunctionPass *createX86InsertX87waitPass();
161161
FunctionPass *createX86PartialReductionPass();
162162

163163
InstructionSelector *createX86InstructionSelector(const X86TargetMachine &TM,
164-
X86Subtarget &,
165-
X86RegisterBankInfo &);
164+
const X86Subtarget &,
165+
const X86RegisterBankInfo &);
166166

167167
FunctionPass *createX86LoadValueInjectionLoadHardeningPass();
168168
FunctionPass *createX86LoadValueInjectionRetHardeningPass();

0 commit comments

Comments
 (0)