Skip to content

Commit 94d8231

Browse files
authored
[LLDB] Mark TestCallStdStringFunction as XPASS on Windows (#146835)
#146562 made [TestCallStdStringFunction](https://github.com/llvm/llvm-project/blob/bd6cd92984e7a30cb91e4f069a0bacc5c582a234/lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py) unexpectedly pass on Windows. The test now passes, because `expression str` now prints the "raw" string object, which happens to include the string "Hello world". Previously, this resulted in an error: ``` (lldb) expression str (std::string) $0 = { _Mypair = { _Myval2 = { _Bx = (_Buf = "Hello world", _Ptr = "", _Alias = "Hello world") _Mysize = 11 _Myres = 15 } } } (lldb) type summary add std::string --summary-string "${var._M_dataplus._M_p}" ^^^ previous summary ^^^ (lldb) expression str (std::string) $1 = error: summary string parsing error ``` #143177 will eventually add the correct summary for MSVC STL strings. Relates to #22139
1 parent 431507d commit 94d8231

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lldb/test/API/commands/expression/call-function/TestCallStdStringFunction.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class ExprCommandCallFunctionTestCase(TestBase):
1212
@expectedFailureAll(
1313
compiler="icc", bugnumber="llvm.org/pr14437, fails with ICC 13.1"
1414
)
15-
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
1615
@skipIf(compiler="clang", compiler_version=["<", "9.0"])
1716
def test_with(self):
1817
"""Test calling std::String member function."""

0 commit comments

Comments
 (0)