Lowering alignment attribute from memref.load/store to LLVM

Author: tyb0807

mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

@@ -841,8 +841,8 @@ struct LoadOpLowering : public LoadStoreOpLowering<memref::LoadOp> {
                                          adaptor.getMemref(),
                                          adaptor.getIndices(), kNoWrapFlags);
     rewriter.replaceOpWithNewOp<LLVM::LoadOp>(
-        loadOp, typeConverter->convertType(type.getElementType()), dataPtr, 0,
-        false, loadOp.getNontemporal());
+        loadOp, typeConverter->convertType(type.getElementType()), dataPtr,
+        loadOp.getAlignment().value_or(0), false, loadOp.getNontemporal());
     return success();
   }
 };
@@ -864,7 +864,8 @@ struct StoreOpLowering : public LoadStoreOpLowering<memref::StoreOp> {
         getStridedElementPtr(rewriter, op.getLoc(), type, adaptor.getMemref(),
                              adaptor.getIndices(), kNoWrapFlags);
     rewriter.replaceOpWithNewOp<LLVM::StoreOp>(op, adaptor.getValue(), dataPtr,
-                                               0, false, op.getNontemporal());
+                                               op.getAlignment().value_or(0),
+                                               false, op.getNontemporal());
     return success();
   }
 };

mlir/test/Conversion/MemRefToLLVM/convert-static-memref-ops.mlir

@@ -148,6 +148,15 @@ func.func @static_load(%static : memref<10x42xf32>, %i : index, %j : index) {
 
 // -----
 
+// CHECK-LABEL: func @aligned_load(
+func.func @aligned_load(%static : memref<10x42xf32>, %i : index, %j : index) {
+// CHECK:  llvm.load %{{.*}} {alignment = 16 : i64} : !llvm.ptr -> f32
+  %0 = memref.load %static[%i, %j] { alignment = 16 } : memref<10x42xf32>
+  return
+}
+
+// -----
+
 // CHECK-LABEL: func @zero_d_store
 func.func @zero_d_store(%arg0: memref<f32>, %arg1: f32) {
 // CHECK: %[[ptr:.*]] = llvm.extractvalue %[[ld:.*]][1] : !llvm.struct<(ptr, ptr, i64)>
@@ -177,6 +186,16 @@ func.func @static_store(%static : memref<10x42xf32>, %i : index, %j : index, %va
 
 // -----
 
+// CHECK-LABEL: func @aligned_store
+func.func @aligned_store(%static : memref<10x42xf32>, %i : index, %j : index, %val : f32) {
+// CHECK: llvm.store %{{.*}}, %{{.*}} {alignment = 16 : i64} : f32, !llvm.ptr
+
+  memref.store %val, %static[%i, %j] { alignment = 16 } : memref<10x42xf32>
+  return
+}
+
+// -----
+
 // CHECK-LABEL: func @static_memref_dim
 func.func @static_memref_dim(%static : memref<42x32x15x13x27xf32>) {
 // CHECK:  llvm.mlir.constant(42 : index) : i64