Skip to content

Commit 7b1680e

Browse files
committed
review comments
1 parent bf252b5 commit 7b1680e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

flang/include/flang/Optimizer/Dialect/FIROps.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3667,10 +3667,10 @@ def fir_DeclareReductionOp : fir_Op<"declare_reduction", [IsolatedFromAbove,
36673667
let summary = "declares a reduction kind";
36683668
let description = [{
36693669
Note: this operation is adapted from omp::DeclareReductionOp. There is a lot
3670-
duplication at the moment. TODO Combined both ops into one. See:
3670+
duplication at the moment. TODO Combine both ops into one. See:
36713671
https://discourse.llvm.org/t/dialect-for-data-locality-sharing-specifiers-clauses-in-openmp-openacc-and-do-concurrent/86108.
36723672

3673-
Declares an `do concurrent` reduction. This requires two mandatory and three
3673+
Declares a `do concurrent` reduction. This requires two mandatory and three
36743674
optional regions.
36753675

36763676
1. The optional alloc region specifies how to allocate the thread-local

flang/lib/Lower/Bridge.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2117,10 +2117,9 @@ class FirConverter : public Fortran::lower::AbstractConverter {
21172117
llvm::SmallVector<mlir::Attribute> reductionDeclSymbols;
21182118
llvm::SmallVector<mlir::Attribute> nestReduceAttrs;
21192119

2120-
for (const auto &reduceOp : info.reduceOperatorList) {
2120+
for (const auto &reduceOp : info.reduceOperatorList)
21212121
nestReduceAttrs.push_back(
21222122
fir::ReduceAttr::get(builder->getContext(), reduceOp));
2123-
}
21242123

21252124
llvm::SmallVector<mlir::Value> reduceVars;
21262125
Fortran::lower::omp::ReductionProcessor rp;
@@ -2556,7 +2555,8 @@ class FirConverter : public Fortran::lower::AbstractConverter {
25562555

25572556
builder->setInsertionPointToEnd(loopWrapperOp.getBody());
25582557
auto loopOp = builder->create<fir::DoConcurrentLoopOp>(
2559-
loc, nestLBs, nestUBs, nestSts, nullptr, /*local_vars=*/std::nullopt,
2558+
loc, nestLBs, nestUBs, nestSts, /*loopAnnotation=*/nullptr,
2559+
/*local_vars=*/std::nullopt,
25602560
/*local_syms=*/nullptr, /*reduce_vars=*/std::nullopt,
25612561
/*reduce_byref=*/nullptr, /*reduce_syms=*/nullptr,
25622562
/*reduce_attrs=*/nullptr);

0 commit comments

Comments
 (0)