Skip to content

Commit 7891270

Browse files
committed
[lldb][Windows] Fix compilation warnings
As seen on Linaro's Windows on Arm bot. C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\source\Host\windows\MainLoopWindows.cpp(80,25): warning: missing field 'InternalHigh' initializer [-Wmissing-field-initializers] 80 | OVERLAPPED ov = {0}; | ^ C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\source\Host\windows\MainLoopWindows.cpp(135,8): warning: 'WillPoll' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] 135 | void WillPoll() { | ^ C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\include\lldb/Host/windows/MainLoopWindows.h(40,18): note: overridden virtual function is here 40 | virtual void WillPoll() {} | ^ C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\source\Host\windows\MainLoopWindows.cpp(142,8): warning: 'DidPoll' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] 142 | void DidPoll() { | ^ C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\include\lldb/Host/windows/MainLoopWindows.h(41,18): note: overridden virtual function is here 41 | virtual void DidPoll() {} | ^ C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\source\Host\windows\MainLoopWindows.cpp(80,25): warning: missing field 'InternalHigh' initializer [-Wmissing-field-initializers] 80 | OVERLAPPED ov = {0}; | ^
1 parent d8023e7 commit 7891270

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lldb/source/Host/windows/MainLoopWindows.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ class PipeEvent : public MainLoopWindows::IOEvent {
7777
do {
7878
char buf[1];
7979
DWORD bytes_read = 0;
80-
OVERLAPPED ov = {0};
80+
OVERLAPPED ov;
81+
ZeroMemory(&ov, sizeof(ov));
8182
// Block on a 0-byte read; this will only resume when data is
8283
// available in the pipe. The pipe must be PIPE_WAIT or this thread
8384
// will spin.
@@ -132,14 +133,14 @@ class SocketEvent : public MainLoopWindows::IOEvent {
132133

133134
~SocketEvent() override { WSACloseEvent(m_event); }
134135

135-
void WillPoll() {
136+
void WillPoll() override {
136137
int result =
137138
WSAEventSelect(m_socket, m_event, FD_READ | FD_ACCEPT | FD_CLOSE);
138139
assert(result == 0);
139140
UNUSED_IF_ASSERT_DISABLED(result);
140141
}
141142

142-
void DidPoll() {
143+
void DidPoll() override {
143144
int result = WSAEventSelect(m_socket, WSA_INVALID_EVENT, 0);
144145
assert(result == 0);
145146
UNUSED_IF_ASSERT_DISABLED(result);

0 commit comments

Comments
 (0)