Skip to content

Commit 773575f

Browse files
committed
[CMake] Configure ccache using command line options
Since ccache 4.8, it is possible to pass configuration options directly to ccache on the command line as opposed to through environment variables. This is the intended way for CMake to configure ccache, as described on the GitHub wiki for the project: https://github.com/ccache/ccache/wiki/CMake This should allow for uniform ccache configuration that does not rely on platform-specific environment setup. Rework the way ccache is configured by LLVM accordingly. Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>
1 parent 0e98817 commit 773575f

File tree

1 file changed

+25
-14
lines changed

1 file changed

+25
-14
lines changed

llvm/CMakeLists.txt

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -271,30 +271,41 @@ set(LLVM_CCACHE_BUILD OFF CACHE BOOL "Set to ON for a ccache enabled build")
271271
if(LLVM_CCACHE_BUILD)
272272
find_program(CCACHE_PROGRAM ccache)
273273
if(CCACHE_PROGRAM)
274+
# ccache --version example output: "ccache version 4.9.1\n(..)"
275+
execute_process(COMMAND ${CCACHE_PROGRAM} --version OUTPUT_VARIABLE CCACHE_VERSION_STR)
276+
string(REGEX MATCH "[0-9]+\.[0-9]+\.?[0-9]*" CCACHE_VERSION "${CCACHE_VERSION_STR}")
277+
274278
set(LLVM_CCACHE_MAXSIZE "" CACHE STRING "Size of ccache")
275279
set(LLVM_CCACHE_DIR "" CACHE STRING "Directory to keep ccached data")
276-
set(LLVM_CCACHE_PARAMS "CCACHE_CPP2=yes CCACHE_HASHDIR=yes"
277-
CACHE STRING "Parameters to pass through to ccache")
278280

279-
if(NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
280-
set(CCACHE_PROGRAM "${LLVM_CCACHE_PARAMS} ${CCACHE_PROGRAM}")
281+
# ccache only supports passing options on the command line from version 4.8.0
282+
# use a workaround with ad-hoc environment variables for older versions
283+
if (CCACHE_VERSION VERSION_LESS "4.8.0")
284+
set(LLVM_CCACHE_PARAMS CCACHE_CPP2=yes CCACHE_HASHDIR=yes)
285+
286+
set(launcher_params ${LLVM_CCACHE_PARAMS})
281287
if (LLVM_CCACHE_MAXSIZE)
282-
set(CCACHE_PROGRAM "CCACHE_MAXSIZE=${LLVM_CCACHE_MAXSIZE} ${CCACHE_PROGRAM}")
288+
set(launcher_params CCACHE_MAXSIZE=${LLVM_CCACHE_MAXSIZE} ${launcher_params})
283289
endif()
284290
if (LLVM_CCACHE_DIR)
285-
set(CCACHE_PROGRAM "CCACHE_DIR=${LLVM_CCACHE_DIR} ${CCACHE_PROGRAM}")
291+
set(launcher_params CCACHE_DIR=${LLVM_CCACHE_DIR} ${launcher_params})
286292
endif()
287-
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CCACHE_PROGRAM})
293+
set(launcher ${launcher_params} ${CCACHE_PROGRAM})
288294
else()
289-
if(LLVM_CCACHE_MAXSIZE OR LLVM_CCACHE_DIR OR
290-
NOT LLVM_CCACHE_PARAMS MATCHES "CCACHE_CPP2=yes CCACHE_HASHDIR=yes")
291-
message(FATAL_ERROR "Ccache configuration through CMake is not supported on Windows. Please use environment variables.")
295+
set(LLVM_CCACHE_PARAMS run_second_cpp=true hash_dir=true)
296+
297+
set(launcher_params ${LLVM_CCACHE_PARAMS})
298+
if (LLVM_CCACHE_MAXSIZE)
299+
set(launcher_params max_size=${LLVM_CCACHE_MAXSIZE} ${launcher_params})
292300
endif()
293-
# RULE_LAUNCH_COMPILE should work with Ninja but currently has issues
294-
# with cmd.exe and some MSVC tools other than cl.exe
295-
set(CMAKE_C_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
296-
set(CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
301+
if (LLVM_CCACHE_DIR)
302+
set(launcher_params cache_dir=${LLVM_CCACHE_DIR} ${launcher_params})
303+
endif()
304+
set(launcher ${CCACHE_PROGRAM} ${launcher_params})
297305
endif()
306+
307+
set(CMAKE_C_COMPILER_LAUNCHER ${launcher})
308+
set(CMAKE_CXX_COMPILER_LAUNCHER ${launcher})
298309
else()
299310
message(FATAL_ERROR "Unable to find the program ccache. Set LLVM_CCACHE_BUILD to OFF")
300311
endif()

0 commit comments

Comments
 (0)