Skip to content

Commit 72b40f7

Browse files
authored
[lldb] Delete unused DWARFDataExtractor methods (#146356)
They are left over from our previous attempt at DWARF64. The new attempt is not using them, and they also don't have equivalents in the llvm DWARFDataExtractor class.
1 parent 84e8274 commit 72b40f7

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,10 @@
77
//===----------------------------------------------------------------------===//
88

99
#include "DWARFDataExtractor.h"
10-
#include "llvm/ADT/StringRef.h"
10+
#include "llvm/ADT/ArrayRef.h"
1111

1212
namespace lldb_private {
1313

14-
uint64_t
15-
DWARFDataExtractor::GetDWARFInitialLength(lldb::offset_t *offset_ptr) const {
16-
return GetU32(offset_ptr);
17-
}
18-
19-
dw_offset_t
20-
DWARFDataExtractor::GetDWARFOffset(lldb::offset_t *offset_ptr) const {
21-
return GetMaxU64(offset_ptr, GetDWARFSizeOfOffset());
22-
}
23-
2414
llvm::DWARFDataExtractor DWARFDataExtractor::GetAsLLVMDWARF() const {
2515
return llvm::DWARFDataExtractor(llvm::ArrayRef(GetDataStart(), GetByteSize()),
2616
GetByteOrder() == lldb::eByteOrderLittle,

lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#ifndef LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
1010
#define LLDB_SOURCE_PLUGINS_SYMBOLFILE_DWARF_DWARFDATAEXTRACTOR_H
1111

12-
#include "lldb/Core/dwarf.h"
1312
#include "lldb/Utility/DataExtractor.h"
1413
#include "llvm/DebugInfo/DWARF/DWARFDataExtractor.h"
1514

@@ -23,13 +22,6 @@ class DWARFDataExtractor : public DataExtractor {
2322
lldb::offset_t length)
2423
: DataExtractor(data, offset, length) {}
2524

26-
uint64_t GetDWARFInitialLength(lldb::offset_t *offset_ptr) const;
27-
28-
dw_offset_t GetDWARFOffset(lldb::offset_t *offset_ptr) const;
29-
30-
size_t GetDWARFSizeofInitialLength() const { return 4; }
31-
size_t GetDWARFSizeOfOffset() const { return 4; }
32-
3325
llvm::DWARFDataExtractor GetAsLLVMDWARF() const;
3426
llvm::DataExtractor GetAsLLVM() const;
3527
};

0 commit comments

Comments
 (0)