Mark PartialReductionRecipe as not having side effects

SamTebbs33 · SamTebbs33 · commit 6ec61b28625f · 2025-06-02T17:13:05.000+01:00
diff --git a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
@@ -159,6 +159,7 @@ bool VPRecipeBase::mayHaveSideEffects() const {
   case VPWidenIntrinsicSC:
     return cast<VPWidenIntrinsicRecipe>(this)->mayHaveSideEffects();
   case VPBlendSC:
+  case VPPartialReductionSC:
   case VPReductionEVLSC:
   case VPReductionSC:
   case VPExtendedReductionSC:
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -2941,7 +2941,6 @@ tryToCreateAbstractPartialReductionRecipe(VPPartialReductionRecipe *PRed) {
                                                        Ext0->getResultType());
   AbstractR->insertBefore(PRed);
   PRed->replaceAllUsesWith(AbstractR);
-  PRed->eraseFromParent();
 }
 
 void VPlanTransforms::convertToAbstractRecipes(VPlan &Plan, VPCostContext &Ctx,

Original file line number	Diff line number	Diff line change
`@@ -2941,7 +2941,6 @@ tryToCreateAbstractPartialReductionRecipe(VPPartialReductionRecipe *PRed) {`
`2941`	`2941`	`Ext0->getResultType());`
`2942`	`2942`	`AbstractR->insertBefore(PRed);`
`2943`	`2943`	`PRed->replaceAllUsesWith(AbstractR);`
`2944`		`- PRed->eraseFromParent();`
`2945`	`2944`	`}`
`2946`	`2945`
`2947`	`2946`	`void VPlanTransforms::convertToAbstractRecipes(VPlan &Plan, VPCostContext &Ctx,`