review feedback

Author: modiking

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

@@ -3014,8 +3014,8 @@ def IsGenericAddressSpace : CPred<"llvm::cast<LLVM::LLVMPointerType>($_self).get
 def IsSharedAddressSpace : CPred<"llvm::cast<LLVM::LLVMPointerType>($_self).getAddressSpace() == 3">;
 def IsSharedClusterAddressSpace : CPred<"llvm::cast<LLVM::LLVMPointerType>($_self).getAddressSpace() == 7">;
 
-class NVVM_AddressSpaceMapping<string inputArg, string resultArg> : 
-    PredOpTrait<"valid address space mapping for NVVM mapa operation",
+class NVVM_MapaASCheck<string inputArg, string resultArg> : 
+    PredOpTrait<"Valid address-space check(or mapping) for mapa Op",
                 Or<[
                   // Generic -> Generic
                   And<[
@@ -3030,7 +3030,7 @@ class NVVM_AddressSpaceMapping<string inputArg, string resultArg> :
                 ]>>;
 
 def NVVM_MapaOp: NVVM_Op<"mapa",
-    [NVVM_AddressSpaceMapping<"a", "res">, NVVMRequiresSM<90>]> {
+    [NVVM_MapaASCheck<"a", "res">, NVVMRequiresSM<90>]> {
   let results = (outs AnyTypeOf<[LLVM_PointerGeneric, LLVM_PointerSharedCluster]>:$res);
   let arguments = (ins AnyTypeOf<[LLVM_PointerGeneric, LLVM_PointerShared]>:$a, I32:$b);
 

mlir/test/Dialect/LLVMIR/invalid.mlir

@@ -1201,7 +1201,7 @@ func.func @cp_async(%arg0: !llvm.ptr<3>, %arg1: !llvm.ptr<1>) {
 // -----
 
 func.func @mapa(%a: !llvm.ptr, %b : i32) {
-  // expected-error @below {{'nvvm.mapa' op failed to verify that valid address space mapping for NVVM mapa operation}}
+  // expected-error @below {{'nvvm.mapa' op failed to verify that Valid address-space check(or mapping) for mapa Op}}
   %0 = nvvm.mapa %a, %b: !llvm.ptr -> !llvm.ptr<7>
   return
 }