Skip to content

Commit 6a9df5b

Browse files
committed
Revert "[lldb][asan] Add temporary logging to ReportRetriever"
This reverts commit 39a4da2. We skipped the failing tests in `6cc8b0bef07f4270303bec0fc203f251a2fde262`.
1 parent dd21aac commit 6a9df5b

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

lldb/source/Plugins/InstrumentationRuntime/Utility/ReportRetriever.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "lldb/Core/Module.h"
1515
#include "lldb/Expression/UserExpression.h"
1616
#include "lldb/Target/InstrumentationRuntimeStopInfo.h"
17-
#include "lldb/Utility/LLDBLog.h"
1817
#include "lldb/ValueObject/ValueObject.h"
1918

2019
using namespace lldb;
@@ -85,8 +84,6 @@ ReportRetriever::RetrieveReportData(const ProcessSP process_sp) {
8584
options.SetLanguage(eLanguageTypeObjC_plus_plus);
8685

8786
if (auto m = GetPreferredAsanModule(process_sp->GetTarget())) {
88-
LLDB_LOGF(GetLog(LLDBLog::Expressions), "Using preferred ASAN module: %s",
89-
m->GetFileSpec().GetFilename().AsCString(""));
9087
SymbolContextList sc_list;
9188
sc_list.Append(SymbolContext(std::move(m)));
9289
options.SetPreferredSymbolContexts(std::move(sc_list));
@@ -108,16 +105,11 @@ ReportRetriever::RetrieveReportData(const ProcessSP process_sp) {
108105
return StructuredData::ObjectSP();
109106
}
110107

111-
LLDB_LOGF(GetLog(LLDBLog::Expressions),
112-
"Successfully ran ASAN report retriever utility expression");
113-
114108
int present = return_value_sp->GetValueForExpressionPath(".present")
115109
->GetValueAsUnsigned(0);
116110
if (present != 1)
117111
return StructuredData::ObjectSP();
118112

119-
LLDB_LOGF(GetLog(LLDBLog::Expressions), "Retrieving report.1");
120-
121113
addr_t pc =
122114
return_value_sp->GetValueForExpressionPath(".pc")->GetValueAsUnsigned(0);
123115
addr_t bp =
@@ -143,8 +135,6 @@ ReportRetriever::RetrieveReportData(const ProcessSP process_sp) {
143135
if (!dict)
144136
return StructuredData::ObjectSP();
145137

146-
LLDB_LOGF(GetLog(LLDBLog::Expressions), "Retrieving report.2");
147-
148138
dict->AddStringItem("instrumentation_class", "AddressSanitizer");
149139
dict->AddStringItem("stop_type", "fatal_error");
150140
dict->AddIntegerItem("pc", pc);

lldb/test/API/functionalities/asan/TestReportData.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ def setUp(self):
3939
self.col_crash = 16
4040

4141
def asan_tests(self, libsanitizers=False):
42-
if libsanitizers:
43-
self.runCmd("log enable lldb expr")
44-
4542
target = self.createTestTarget()
4643

4744
if libsanitizers:

0 commit comments

Comments
 (0)