[StaticAnalyzer] Remove unnecessary casts (NFC) (#146706)

kazutakahirata · web-flow · commit 4461de2e5139 · 2025-07-02T09:32:15.000-07:00
N is already of ExplodedNode *.
diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h
@@ -448,14 +448,15 @@ class ExplodedNodeSet {
 
 public:
   ExplodedNodeSet(ExplodedNode *N) {
-    assert(N && !static_cast<ExplodedNode*>(N)->isSink());
+    assert(N && !N->isSink());
     Impl.insert(N);
   }
 
   ExplodedNodeSet() = default;
 
   void Add(ExplodedNode *N) {
-    if (N && !static_cast<ExplodedNode*>(N)->isSink()) Impl.insert(N);
+    if (N && !N->isSink())
+      Impl.insert(N);
   }
 
   using iterator = ImplTy::iterator;

Original file line number	Diff line number	Diff line change
`@@ -448,14 +448,15 @@ class ExplodedNodeSet {`
`448`	`448`
`449`	`449`	`public:`
`450`	`450`	`ExplodedNodeSet(ExplodedNode *N) {`
`451`		`- assert(N && !static_cast<ExplodedNode*>(N)->isSink());`
	`451`	`+ assert(N && !N->isSink());`
`452`	`452`	`Impl.insert(N);`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`ExplodedNodeSet() = default;`
`456`	`456`
`457`	`457`	`void Add(ExplodedNode *N) {`
`458`		`- if (N && !static_cast<ExplodedNode*>(N)->isSink()) Impl.insert(N);`
	`458`	`+ if (N && !N->isSink())`
	`459`	`+ Impl.insert(N);`
`459`	`460`	`}`
`460`	`461`
`461`	`462`	`using iterator = ImplTy::iterator;`