Skip to content

Commit 425359a

Browse files
authored
[experimental] Ask copilot to check perf profile degradation (#146271)
We can optionally add copilot as a reviewer. As per [documentation](https://docs.github.com/en/copilot/how-tos/agents/copilot-code-review/using-copilot-code-review#customizing-copilots-reviews-with-custom-instructions), we can customize the review. This PR asks it to pay attention to the kind of code that might corrupt performance data, or, in the case of sample profiling, result in poor profiles by dropping debug info.
1 parent 00cdaa5 commit 425359a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/copilot-instructions.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
When performing a code review, pay close attention to code modifying a function's
2+
control flow. Could the change result in the corruption of performance profile
3+
data? Could the change result in invalid debug information, in particular for
4+
branches and calls?

0 commit comments

Comments
 (0)