Skip to content

Commit 310cae6

Browse files
committed
Remove sym_name
1 parent b22b7de commit 310cae6

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

mlir/include/mlir/Dialect/EmitC/IR/EmitC.td

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,16 +1692,16 @@ def BufferMapOp
16921692
Example:
16931693

16941694
```mlir
1695-
emitc.buffer_map reflection_map [ @field1, @field2, @field3 ]
1695+
emitc.buffer_map [ @field1, @field2, @field3 ]
16961696
```
16971697

16981698
This generates C++ code like:
16991699

17001700
```cpp
1701-
const std::map<std::string, char*> _reflection_map {
1702-
{ "field1", reinterpret_cast<char*>(&field1) },
1703-
{ "field2", reinterpret_cast<char*>(&field2) },
1704-
{ "field3", reinterpret_cast<char*>(&field3) }
1701+
const std::map<std::string, char*> _buffer_map {
1702+
{ "some_feature", reinterpret_cast<char*>(&some_feature) },
1703+
{ "another_feature", reinterpret_cast<char*>(&another_feature) },
1704+
{ "input_tense", reinterpret_cast<char*>(&input_tense) }
17051705
};
17061706

17071707
char* getBufferForName(const std::string& name) const {
@@ -1711,12 +1711,10 @@ def BufferMapOp
17111711
```
17121712
}];
17131713

1714-
let arguments = (ins SymbolNameAttr:$sym_name,
1715-
Arg<OptionalAttr<ArrayAttr>, "field names">:$fields);
1714+
let arguments = (ins Arg<OptionalAttr<ArrayAttr>, "field names">:$fields);
17161715

17171716
let results = (outs);
1718-
let builders = [];
1719-
let assemblyFormat = "$sym_name $fields attr-dict";
1717+
let assemblyFormat = "$fields attr-dict";
17201718
}
17211719

17221720
#endif // MLIR_DIALECT_EMITC_IR_EMITC

mlir/lib/Dialect/EmitC/Transforms/WrapFuncInClass.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ class WrapFuncInClass : public OpRewritePattern<emitc::FuncOp> {
8080

8181
if (!bufferFieldAttrs.empty()) {
8282
ArrayAttr fieldsArrayAttr = rewriter.getArrayAttr(bufferFieldAttrs);
83-
rewriter.create<emitc::BufferMapOp>(funcOp.getLoc(), "reflection_map",
84-
fieldsArrayAttr);
83+
rewriter.create<emitc::BufferMapOp>(funcOp.getLoc(), fieldsArrayAttr);
8584
}
8685

8786
rewriter.setInsertionPointToEnd(&newClassOp.getBody().front());

0 commit comments

Comments
 (0)