You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[lldb][test] Merge MSVC STL std::(u8)string tests into generic directory (#147525)
Now that most STL formatter tests have been moved to `generic`. Do the
same for the MSVC tests (which are currently just for `std::string`).
The `std::string` test was mostly the same (MSVC just had 1 additional
check, which I moved over).
We also only tested `u8string` with MSVC. So i moved those into
`generic` as-is. I kept it separate from the existing std::string tests
since it requires c++20.
The tests are currently failing for libc++ and libstdc++ because MSVC
had a test case which checked that:
```
std::string overwritten_zero("abc");
const_cast<char *>(overwritten_zero.data())[3] = 'd';
```
prints as `"abc"`. But libc++ and libstdc++ print it as `"abcd"` (which
seems like the more correct thing to do?)
Copy file name to clipboardExpand all lines: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py
+79-3Lines changed: 79 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -124,6 +124,11 @@ def test_libstdcxx(self):
124
124
self.build(dictionary={"USE_LIBSTDCPP": 1})
125
125
self.do_test()
126
126
127
+
@add_test_categories(["msvcstl"])
128
+
deftest_msvc(self):
129
+
self.build()
130
+
self.do_test()
131
+
127
132
defdo_test_multibyte(self):
128
133
lldbutil.run_to_source_breakpoint(
129
134
self, "Set break point at this line.", self.main_spec
Copy file name to clipboardExpand all lines: lldb/test/API/functionalities/data-formatter/data-formatter-stl/msvcstl/string/TestDataFormatterMsvcStlString.py
0 commit comments