Skip to content

Commit 1afbce8

Browse files
committed
Update some comments
1 parent b65ab58 commit 1afbce8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,7 @@ LowerCallResults(MachineInstr &CallResults, DebugLoc DL, MachineBasicBlock *BB,
840840

841841
if (IsIndirect) {
842842
// Placeholder for the type index.
843+
// This gets replaced with the correct value in WebAssemblyMCInstLower.cpp
843844
MIB.addImm(0);
844845
// The table into which this call_indirect indexes.
845846
MCSymbolWasm *Table = IsFuncrefCall

llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ void WebAssemblyMCInstLower::lower(const MachineInstr *MI,
220220
// The return type needs special handling because it could be void.
221221
auto ReturnType = static_cast<WebAssembly::BlockType>(
222222
CImm.extractBitsAsZExtValue(64, (NumWords - 1) * 64));
223-
assert(ReturnType != WebAssembly::BlockType::Invalid);
224223
SmallVector<wasm::ValType, 2> Returns;
225224
switch (ReturnType) {
226225
case WebAssembly::BlockType::Invalid:
@@ -271,7 +270,7 @@ void WebAssemblyMCInstLower::lower(const MachineInstr *MI,
271270
if (DescIndex < Desc.NumOperands) {
272271
const MCOperandInfo &Info = Desc.operands()[DescIndex];
273272
// Replace type index placeholder with actual type index. The type index
274-
// placeholders are immedates or CImmediates and have an operand type of
273+
// placeholders are Immediates and have an operand type of
275274
// OPERAND_TYPEINDEX or OPERAND_SIGNATURE.
276275
if (Info.OperandType == WebAssembly::OPERAND_TYPEINDEX) {
277276
// Lower type index placeholder for a CALL_INDIRECT instruction

0 commit comments

Comments
 (0)