Tests added

Author: lloc

includes/MslsCustomFilter.php

@@ -41,9 +41,9 @@ public static function init() {
 	 * Echo's select tag with list of blogs
 	 * @uses selected
 	 */
-	public function add_filter() {
+	public function add_filter(): void {
 		$id = (
-		filter_has_var( INPUT_GET, 'msls_filter' ) ?
+		    filter_has_var( INPUT_GET, 'msls_filter' ) ?
 			filter_input( INPUT_GET, 'msls_filter', FILTER_SANITIZE_NUMBER_INT ) :
 			''
 		);

patchwork.json

@@ -1 +1 @@
-{"redefinable-internals": ["filter_input_array"]}
+{"redefinable-internals": ["filter_input_array", "filter_has_var"]}

tests/TestMslsCustomColumnTaxonomy.php

@@ -3,7 +3,6 @@
 namespace lloc\MslsTests;
 
 use lloc\Msls\MslsBlogCollection;
-use lloc\Msls\MslsCustomColumn;
 use lloc\Msls\MslsCustomColumnTaxonomy;
 use lloc\Msls\MslsOptions;
 

tests/TestMslsCustomFilter.php

@@ -5,21 +5,40 @@
 use lloc\Msls\MslsBlogCollection;
 use lloc\Msls\MslsCustomFilter;
 use lloc\Msls\MslsOptions;
-use Mockery\Mock;
+use Brain\Monkey\Functions;
 
 class TestMslsCustomFilter extends MslsUnitTestCase {
 
-	public function test_execute_filter(): void {
-		$options = \Mockery::mock( MslsOptions::class );
+    protected function setUp(): void
+    {
+        parent::setUp(); // TODO: Change the autogenerated stub
 
-		$collection = \Mockery::mock( MslsBlogCollection::class );
-		$collection->shouldReceive( 'get' )->once()->andReturn( [] );
+        $options = \Mockery::mock( MslsOptions::class );
 
-		$query = \Mockery::mock( 'WP_Query' );
+        $collection = \Mockery::mock( MslsBlogCollection::class );
+        $collection->shouldReceive( 'get' )->once()->andReturn( [] );
 
-		$obj = new MslsCustomFilter( $options, $collection );
+        $this->test = new MslsCustomFilter( $options, $collection );
 
-		$this->assertFalse( $obj->execute_filter( $query ) );
+    }
+
+    public function test_execute_filter(): void {
+        $query = \Mockery::mock( 'WP_Query' );
+
+        $this->assertFalse( $this->test->execute_filter( $query ) );
 	}
 
+    public function test_execute_filter_with_filter_input(): void {
+        Functions\expect('filter_has_var')->once()->with( INPUT_GET, 'msls_filter' )->andReturn( true );
+
+        $query = \Mockery::mock( 'WP_Query' );
+
+        $this->assertFalse( $this->test->execute_filter( $query ) );
+    }
+
+    public function test_add_filter(): void {
+        $this->expectOutputString('' );
+
+        $this->test->add_filter();
+    }
 }