MslsAdminBar tested

Author: lloc

includes/MslsAdminBar.php

@@ -4,44 +4,73 @@
 
 class MslsAdminBar {
 
+	protected string $icon_type;
+
+	protected MslsBlogCollection $blog_collection;
+
+	public function __construct( MslsOptions $options, MslsBlogCollection $blog_collection ) {
+		$this->icon_type       = $options->get_icon_type();
+		$this->blog_collection = $blog_collection;
+	}
 
 	/**
 	 * @codeCoverageIgnore
 	 */
 	public function init(): void {
+		$obj = new MslsAdminBar( msls_options(), msls_blog_collection() );
+
 		if ( is_admin_bar_showing() ) {
-			add_action( 'admin_bar_menu', array( __CLASS__, 'update_admin_bar' ), 999 );
+			add_action( 'admin_bar_menu', array( $obj, 'update_admin_bar' ), 999 );
 		}
 	}
 
 	/**
-	 * @param $wp_admin_bar
-	 *
-	 * @return void
+	 * Callback that updates the admin bar with the blog information
 	 */
-	public static function update_admin_bar( \WP_Admin_Bar $wp_admin_bar ): void {
-		$icon_type = msls_options()->get_icon_type();
-
-		$blog_collection = msls_blog_collection();
-		foreach ( $blog_collection->get_plugin_active_blogs() as $blog ) {
-			$title = $blog->get_blavatar() . $blog->get_title( $icon_type );
-
-			$wp_admin_bar->add_node(
-				array(
-					'id'    => 'blog-' . $blog->userblog_id,
-					'title' => $title,
-				)
-			);
+	public function update_admin_bar( \WP_Admin_Bar $wp_admin_bar ): void {
+		foreach ( $this->blog_collection->get_plugin_active_blogs() as $blog ) {
+			$title = $this->get_title( $blog, true );
+
+			$title && $this->add_node( $wp_admin_bar, 'blog-' . $blog->userblog_id, $title );
 		}
 
-		$blog = $blog_collection->get_current_blog();
-		if ( is_object( $blog ) && method_exists( $blog, 'get_title' ) ) {
-			$wp_admin_bar->add_node(
-				array(
-					'id'    => 'site-name',
-					'title' => $blog->get_title( $icon_type ),
-				)
-			);
+		$blog  = $this->blog_collection->get_current_blog();
+		$title = $this->get_title( $blog );
+
+		$title && $this->add_node( $wp_admin_bar, 'site-name', $title );
+	}
+
+	/**
+	 * Adds node information to an existing node
+	 */
+	public function add_node( \WP_Admin_Bar $wp_admin_bar, string $node_id, string $title ): bool {
+		$node = $wp_admin_bar->get_node( $node_id );
+		if ( is_null( $node ) ) {
+			return false;
 		}
+
+		$wp_admin_bar->add_node(
+			array(
+				'id'    => $node_id,
+				'title' => $title,
+			)
+		);
+
+		return true;
+	}
+
+	/**
+	 * Gets a title with label orflag (depending on the settings) for the blog
+	 *
+	 * It uses a blavatar icon as prefix if $blavatar is set to true
+	 */
+	protected function get_title( ?MslsBlog $blog, bool $blavatar = false ): ?string {
+		if ( is_null( $blog ) ) {
+			return $blog;
+		}
+
+		$prefix = $blavatar ? $blog->get_blavatar() : '';
+
+		return $prefix . $blog->get_title( $this->icon_type );
 	}
 }

includes/MslsPlugin.php

@@ -145,7 +145,7 @@ public function content_filter( string $content ) {
 	}
 
 	/**
-	 * Create filterstring for msls_content_filter()
+	 * Create filter-string for msls_content_filter()
 	 *
 	 * @param string $pref
 	 * @param string $post

tests/phpunit/TestMslsAdminBar.php

@@ -0,0 +1,63 @@
+<?php declare( strict_types=1 );
+
+namespace lloc\MslsTests;
+
+use Brain\Monkey\Functions;
+use lloc\Msls\MslsAdminBar;
+use lloc\Msls\MslsBlog;
+use lloc\Msls\MslsBlogCollection;
+use lloc\Msls\MslsLink;
+use lloc\Msls\MslsOptions;
+
+class TestMslsAdminBar extends MslsUnitTestCase {
+
+
+	public function setUp(): void {
+		parent::setUp();
+
+		$options = \Mockery::mock( MslsOptions::class );
+		$options->shouldReceive( 'get_icon_type' )->andReturn( 'label' );
+
+		$blog_a              = \Mockery::mock( MslsBlog::class );
+		$blog_a->userblog_id = 1;
+		$blog_a->shouldReceive( 'get_title' )->andReturn( 'Blog A' );
+		$blog_a->shouldReceive( 'get_blavatar' )->andReturn( '<div>Blavatar</div>' );
+
+		$blog_b              = \Mockery::mock( MslsBlog::class );
+		$blog_b->userblog_id = 2;
+		$blog_b->shouldReceive( 'get_title' )->andReturn( 'Blog B' );
+		$blog_b->shouldReceive( 'get_blavatar' )->andReturn( '<div>Blavatar</div>' );
+
+		$blog_c = null;
+
+		$collection = \Mockery::mock( MslsBlogCollection::class );
+		$collection->shouldReceive( 'get_current_blog' )->andReturn( $blog_a );
+		$collection->shouldReceive( 'get_plugin_active_blogs' )->andReturn( array( $blog_a, $blog_b, $blog_c ) );
+
+		$this->test = new MslsAdminBar( $options, $collection );
+	}
+
+	public function test_add_node_false(): void {
+		$wp_admin_bar = \Mockery::mock( \WP_Admin_Bar::class );
+		$wp_admin_bar->shouldReceive( 'get_node' )->once()->andReturnNull();
+
+		$this->assertFalse( $this->test->add_node( $wp_admin_bar, 'node-id', 'title' ) );
+	}
+
+	public function test_add_node_true(): void {
+		$wp_admin_bar = \Mockery::mock( \WP_Admin_Bar::class );
+		$wp_admin_bar->shouldReceive( 'get_node' )->once()->andReturn( (object) array() );
+		$wp_admin_bar->shouldReceive( 'add_node' )->once();
+
+		$this->assertTrue( $this->test->add_node( $wp_admin_bar, 'node-id', 'title' ) );
+	}
+
+	public function test_update_admin_bar(): void {
+		$wp_admin_bar = \Mockery::mock( \WP_Admin_Bar::class );
+		$wp_admin_bar->shouldReceive( 'get_node' )->times( 3 )->andReturn( (object) array() );
+		$wp_admin_bar->shouldReceive( 'add_node' )->times( 3 );
+
+		$this->expectOutputString( '' );
+		$this->test->update_admin_bar( $wp_admin_bar );
+	}
+}