MslsLink tested

Author: lloc

includes/MslsLink.php

@@ -66,27 +66,26 @@ public static function get_types_description(): array {
 	 * @return MslsLink
 	 */
 	public static function create( ?int $display ): MslsLink {
+		$types = self::get_types();
+		if ( ! in_array( $display, array_keys( $types ), true ) ) {
+			$display = 0;
+		}
+
+		$obj = new $types[ $display ]();
+
 		if ( has_filter( 'msls_link_create' ) ) {
 			/**
-			 * Returns custom MslsLink-Object
-			 *
 			 * @param int $display
 			 *
 			 * @return MslsLink
-			 * @since 0.9.9
 			 */
-			$obj = apply_filters( 'msls_link_create', $display );
-			if ( is_subclass_of( $obj, __CLASS__ ) ) {
+			$obj = apply_filters( 'msls_link_create', $obj, $display );
+			if ( in_array( __CLASS__, $types ) || is_subclass_of( $obj, __CLASS__ ) ) {
 				return $obj;
 			}
 		}
 
-		$types = self::get_types();
-		if ( ! in_array( $display, array_keys( $types ), true ) ) {
-			$display = 0;
-		}
-
-		return new $types[ $display ]();
+		return $obj;
 	}
 
 	/**

tests/phpunit/TestMslsLink.php

@@ -3,10 +3,25 @@
 namespace lloc\MslsTests;
 
 use Brain\Monkey\Functions;
+use Brain\Monkey\Filters;
+use Hoa\Iterator\Filter;
 use lloc\Msls\MslsLink;
 
 class TestMslsLink extends MslsUnitTestCase {
 
+	public function test_create(): void {
+		Functions\expect( 'has_filter' )->once()->with( 'msls_link_create' )->andReturn( true );
+
+		$obj     = new MslsLink();
+		$display = 0;
+
+		Filters\expectApplied( 'msls_link_create' )->once()->andReturn( $obj );
+
+		$obj = MslsLink::create( $display );
+
+		$this->assertInstanceOf( MslsLink::class, $obj );
+	}
+
 	public function test_get_types(): void {
 		$this->assertCount( 4, MslsLink::get_types() );
 	}