Merge pull request #312 from lloc/refactoring-version-2-8

MslsOptionsTaxTerm fully tested

Author: lloc

includes/MslsOptionsTaxTerm.php

@@ -9,19 +9,9 @@
  */
 class MslsOptionsTaxTerm extends MslsOptionsTax {
 
-	/**
-	 * Base option
-	 *
-	 * @var string
-	 */
-	protected $base_option = 'tag_base';
+	const BASE_OPTION = 'tag_base';
 
-	/**
-	 * Base definition
-	 *
-	 * @var string
-	 */
-	protected $base_defined = 'tag';
+	const BASE_DEFINED = 'tag';
 
 	/**
 	 * Rewrite with front
@@ -33,8 +23,8 @@ class MslsOptionsTaxTerm extends MslsOptionsTax {
 	/**
 	 * Check and correct URL
 	 *
-	 * @param string      $url
-	 * @param MslsOptions $options
+	 * @param string             $url
+	 * @param MslsOptionsTaxTerm $options
 	 *
 	 * @return string
 	 */
@@ -43,32 +33,38 @@ public function check_base( $url, $options ) {
 			return $url;
 		}
 
-		global $wp_rewrite;
+		$tax_query    = $options->get_tax_query();
+		$base_defined = self::get_base_defined( $tax_query );
+		$base_option  = self::get_base_option();
 
-		$base_defined = $options->base_defined;
+		if ( $base_defined != $base_option ) {
+			$search  = '/' . $base_defined . '/';
+			$replace = '/' . $base_option . '/';
+			$url     = str_replace( $search, $replace, $url );
+		}
 
-		$permastruct = $wp_rewrite->get_extra_permastruct( $options->get_tax_query() );
+		return $url;
+	}
+
+	protected static function get_base_defined( string $tax_query ): string {
+		global $wp_rewrite;
+
+		$permastruct = $wp_rewrite->get_extra_permastruct( $tax_query );
 		if ( $permastruct ) {
 			$permastruct = explode( '/', $permastruct );
 			end( $permastruct );
 			$permastruct = prev( $permastruct );
 			if ( false !== $permastruct ) {
-				$base_defined = $permastruct;
+				return $permastruct;
 			}
 		}
 
-		$base_option = get_option( $options->base_option );
-		if ( empty( $base_option ) ) {
-			$base_option = $options->base_defined;
-		}
+		return self::BASE_DEFINED;
+	}
 
-		if ( $base_defined != $base_option ) {
-			$search  = '/' . $base_defined . '/';
-			$replace = '/' . $base_option . '/';
-			$count   = 1;
-			$url     = str_replace( $search, $replace, $url, $count );
-		}
+	protected static function get_base_option(): string {
+		$base_option = get_option( self::BASE_OPTION, '' );
 
-		return $url;
+		return $base_option ?: self::BASE_DEFINED;
 	}
 }

tests/TestMslsOptionsTaxTerm.php

@@ -4,16 +4,53 @@
 
 use Brain\Monkey\Functions;
 
+use lloc\Msls\MslsOptions;
 use lloc\Msls\MslsOptionsTaxTerm;
 
 class TestMslsOptionsTaxTerm extends MslsUnitTestCase {
 
-	public function test_object(): void {
-		Functions\expect( 'get_option' )->once()->andReturn( [] );
+	protected function setUp(): void {
+		parent::setUp();
 
-		$obj = new MslsOptionsTaxTerm( 0 );
+		Functions\expect( 'get_option' )->once()->with( 'msls_term_42' )->andReturn( array( 'de_DE' => 42 ) );
 
-		$this->assertIsSTring( $obj->get_postlink( '' ) );
+		$this->test = new MslsOptionsTaxTerm( 42 );
 	}
+	public function test_get_postlink_empty(): void {
+		$this->assertEquals( '', $this->test->get_postlink( '' ) );
+	}
+
+	public function test_check_url_empty(): void {
+		$options = \Mockery::mock( MslsOptionsTaxTerm::class );
+
+		$this->assertEquals( '', $this->test->check_base( null, $options ) );
+		$this->assertEquals( '', $this->test->check_base( '', $options ) );
+		$this->assertEquals( '', $this->test->check_base( false, $options ) );
+	}
+
+	public function test_check_url(): void {
+		global $wp_rewrite;
+
+		$wp_rewrite = \Mockery::mock( 'WP_Rewrite' );
+		$wp_rewrite->shouldReceive( 'get_extra_permastruct' )->andReturn( '/schlagwort/' );
+
+		$options = \Mockery::mock( MslsOptionsTaxTerm::class );
+		$options->shouldReceive( 'get_tax_query' )->andReturn( '' );
 
+		$expected = 'https://example.de/tag/keyword';
+		$this->assertEquals( $expected, $this->test->check_base( 'https://example.de/schlagwort/keyword', $options ) );
+	}
+
+	public function test_check_url_permastruct_false(): void {
+		global $wp_rewrite;
+
+		$wp_rewrite = \Mockery::mock( 'WP_Rewrite' );
+		$wp_rewrite->shouldReceive( 'get_extra_permastruct' )->andReturn( false );
+
+		$options = \Mockery::mock( MslsOptionsTaxTerm::class );
+		$options->shouldReceive( 'get_tax_query' )->andReturn( '' );
+
+		$expected = 'https://example.de/schlagwort/keyword';
+		$this->assertEquals( $expected, $this->test->check_base( $expected, $options ) );
+	}
 }