Merge pull request #358 from lloc/refactoring-2-9

Tests added

Author: lloc

includes/MslsMetaBox.php

@@ -90,7 +90,7 @@ public static function get_suggested_fields( $json, $args ) {
 	 *
 	 * @return MslsMetaBox
 	 */
-	public static function init() {
+	public static function init(): MslsMetaBox {
 		$options = msls_options();
 		$obj     = new static( $options, msls_blog_collection() );
 
@@ -104,9 +104,9 @@ public static function init() {
 	}
 
 	/**
-	 * Add
+	 * Adds the meta box to the post types
 	 */
-	public function add() {
+	public function add(): void {
 		foreach ( MslsPostType::instance()->get() as $post_type ) {
 
 			add_meta_box(
@@ -153,7 +153,7 @@ public function add() {
 	 *
 	 * @uses selected
 	 */
-	public function render_select() {
+	public function render_select(): void {
 		$blogs = $this->collection->get();
 		if ( $blogs ) {
 			global $post;
@@ -269,7 +269,7 @@ public function render_options( $type, $msls_id ): string {
 	 *
 	 * @return string
 	 */
-	public function render_option( $post_id, $msls_id ) {
+	public function render_option( $post_id, $msls_id ): string {
 		return sprintf(
 			'<option value="%s" %s>%s</option>',
 			$post_id,
@@ -283,7 +283,7 @@ public function render_option( $post_id, $msls_id ) {
 	 *
 	 * @param bool $echo Whether the metabox markup should be echoed to the page or not.
 	 */
-	public function render_input() {
+	public function render_input(): void {
 		$blogs = $this->collection->get();
 
 		if ( $blogs ) {
@@ -356,7 +356,7 @@ public function render_input() {
 	 *
 	 * @param int $post_id
 	 */
-	public function set( $post_id ) {
+	public function set( $post_id ): void {
 		if ( $this->is_autosave( $post_id ) || ! $this->verify_nonce() ) {
 			return;
 		}

tests/phpunit/TestMslsMetaBox.php

@@ -95,6 +95,7 @@ public function add_data_provider() {
 
 	/**
 	 * @dataProvider add_data_provider
+	 * @doesNotPerformAssertions
 	 */
 	public function test_add( $post_type, $fcount, $ocount, $content_import, $autocomplete ) {
 		$options                          = \Mockery::mock( MslsOptions::class );
@@ -106,8 +107,6 @@ public function test_add( $post_type, $fcount, $ocount, $content_import, $autoco
 		Functions\expect( '__' )->times( $fcount )->andReturnFirstArg();
 		Functions\expect( 'msls_options' )->times( $ocount )->andReturn( $options );
 
-		$this->expectOutputString( '' );
-
 		$this->test->add();
 	}
 
@@ -233,4 +232,13 @@ public function test_render_input_only_one_blog() {
 
 		$this->test->render_input();
 	}
+
+	/**
+	 * @doesNotPerformAssertions
+	 */
+	public function test_set() {
+		Functions\expect( 'wp_is_post_revision' )->once()->andReturn( false );
+
+		$this->test->set( 13 );
+	}
 }