Optimized code

Author: lloc

includes/MslsCustomFilter.php

@@ -49,12 +49,6 @@ function () {
 	 * @uses selected
 	 */
 	public function add_filter(): void {
-		$id = (
-			filter_has_var( INPUT_GET, self::FILTER_NAME ) ?
-			filter_input( INPUT_GET, self::FILTER_NAME, FILTER_SANITIZE_NUMBER_INT ) :
-			'0'
-		);
-
 		$blogs = $this->collection->get();
 		if ( $blogs ) {
 			$options = array( '' => esc_html( __( 'Show all posts', 'multisite-language-switcher' ) ) );
@@ -65,6 +59,12 @@ public function add_filter(): void {
 				);
 			}
 
+			$id = (
+				filter_has_var( INPUT_GET, self::FILTER_NAME ) ?
+				filter_input( INPUT_GET, self::FILTER_NAME, FILTER_SANITIZE_NUMBER_INT ) :
+				'0'
+			);
+
 			echo ( new Select( self::FILTER_NAME, $options, $id ) )->render();
 		}
 	}
@@ -84,15 +84,15 @@ public function execute_filter( \WP_Query $query ) {
 		$id   = filter_input( INPUT_GET, self::FILTER_NAME, FILTER_SANITIZE_NUMBER_INT );
 		$blog = $this->collection->get_object( intval( $id ) );
 
-		if ( $blog ) {
-			$sql_cache = MslsSqlCacher::create( __CLASS__, __METHOD__ );
+		if ( ! $blog ) {
+			return false;
+		}
 
-			// load post we need to exclude (they already have a translation) from search query
-			$query->query_vars['post__not_in'] = ( new TranslatedPostIdQuery( $sql_cache ) )( $blog->get_language() );
+		$sql_cache = MslsSqlCacher::create( __CLASS__, __METHOD__ );
 
-			return $query;
-		}
+		// load post we need to exclude (they already have a translation) from search query
+		$query->query_vars['post__not_in'] = ( new TranslatedPostIdQuery( $sql_cache ) )( $blog->get_language() );
 
-		return false;
+		return $query;
 	}
 }