Skip to content

Commit a2ce44d

Browse files
shmuelkmayabar
andauthored
fix: max-cpu-loras should be initialized from max-loras (#77)
* Don't initialize ma-cpu-loras. Take max-loras as default Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Update config_test.go - fix test Signed-off-by: Maya Barnea <mayab@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> Signed-off-by: Maya Barnea <mayab@il.ibm.com> Co-authored-by: Maya Barnea <mayab@il.ibm.com>
1 parent 2119638 commit a2ce44d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/llm-d-inference-sim/config.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,10 @@ func (l *loraModulesValue) UnmarshalYAML(unmarshal func(interface{}) error) erro
9292

9393
func newConfig() *configuration {
9494
return &configuration{
95-
Port: vLLMDefaultPort,
96-
MaxLoras: 1,
97-
MaxCPULoras: 1,
98-
MaxNumSeqs: 5,
99-
Mode: modeRandom,
95+
Port: vLLMDefaultPort,
96+
MaxLoras: 1,
97+
MaxNumSeqs: 5,
98+
Mode: modeRandom,
10099
}
101100
}
102101

pkg/llm-d-inference-sim/config_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ var _ = Describe("Simulator configuration", func() {
5454
c := newConfig()
5555
c.Model = model
5656
c.ServedModelNames = []string{c.Model}
57+
c.MaxCPULoras = 1
5758
test := testCase{
5859
name: "simple",
5960
args: []string{"cmd", "--model", model, "--mode", modeRandom},

0 commit comments

Comments
 (0)