[howler] fix: add missing exports, remove incorrect export and remove private Sound (DefinitelyTyped#66222)

* fix: add missing `Howl` global, `HowlerGlobal` type and `window`

* fix: remove incorrect `State` export

* fix: `Sound` is a class

* fix: remove the `Sound` class, it is private and should never be used

* corrected globals and test

* fix test

* use comment flag instead

* fix: object `HowlerGlobal` should not be exported

Author: MrGriefs

types/howler/howler-tests.ts

@@ -1,3 +1,5 @@
+import './test/globals';
+
 import { Howl, Howler } from 'howler';
 
 // Set global volume

types/howler/index.d.ts

@@ -13,12 +13,6 @@ export type HowlErrorCallback = (soundId: number, error: unknown) => void;
 export type SpatialOrientation = [number, number, number];
 export type SpatialPosition = [number, number, number];
 
-export enum State {
-    Unloaded = 'unloaded',
-    Loading = 'loading',
-    Loaded = 'loaded',
-}
-
 export interface SoundSpriteDefinitions {
     [name: string]: [number, number] | [number, number, boolean];
 }
@@ -34,10 +28,6 @@ export interface PannerAttributes {
     rolloffFactor?: number;
 }
 
-export interface Sound {
-    (howl: Howl): this;
-}
-
 export interface HowlListeners {
     /** Fires when the sound has been stopped. The first parameter is the ID of the sound. */
     onstop?: HowlCallback | undefined;
@@ -269,33 +259,43 @@ export class Howl {
     pannerAttr(options: PannerAttributes, id?: number): this;
 }
 
-declare global {
-    class HowlerGlobal {
-        mute(muted: boolean): this;
-        stop(): this;
-
-        volume(): number;
-        volume(volume: number): this;
-
-        codecs(ext: string): boolean;
-        unload(): this;
-        usingWebAudio: boolean;
-        html5PoolSize: number;
-        noAudio: boolean;
-        autoUnlock: boolean;
-        autoSuspend: boolean;
-        ctx: AudioContext;
-        masterGain: GainNode;
-
-        stereo(pan: number): this;
-
-        pos(): SpatialPosition;
-        pos(x: number, y?: number, z?: number): this;
-
-        orientation(): SpatialOrientation;
-        orientation(x: number, y?: number, z?: number, xUp?: number, yUp?: number, zUp?: number): this;
-    }
-    const Howler: HowlerGlobal;
+export interface HowlerGlobal {
+    mute(muted: boolean): this;
+    stop(): this;
+
+    volume(): number;
+    volume(volume: number): this;
+
+    codecs(ext: string): boolean;
+    unload(): this;
+    usingWebAudio: boolean;
+    html5PoolSize: number;
+    noAudio: boolean;
+    autoUnlock: boolean;
+    autoSuspend: boolean;
+    ctx: AudioContext;
+    masterGain: GainNode;
+
+    stereo(pan: number): this;
+
+    pos(): SpatialPosition;
+    pos(x: number, y?: number, z?: number): this;
+
+    orientation(): SpatialOrientation;
+    orientation(x: number, y?: number, z?: number, xUp?: number, yUp?: number, zUp?: number): this;
 }
 
-export const Howler: HowlerGlobal;
+import { Howl as _Howl, HowlerGlobal as _HowlerGlobal } from '.';
+export { Howler };
+
+declare global {
+    // tslint:disable:no-empty-interface
+    interface Howl extends _Howl {}
+    interface HowlerGlobal extends _HowlerGlobal {}
+    var Howl: typeof _Howl;
+    var HowlerGlobal: {
+        prototype: _HowlerGlobal;
+        new (): _HowlerGlobal;
+    };
+    var Howler: HowlerGlobal;
+}

types/howler/test/globals.ts

@@ -0,0 +1,12 @@
+new globalThis.Howl({ src: 'sound.mp3' });
+new this.Howl({ src: 'sound.mp3' });
+new window.Howl({ src: 'sound.mp3' });
+new Howl({ src: 'sound.mp3' });
+
+globalThis.Howler.volume(0.8);
+this.Howler.volume(0.8);
+window.Howler.volume(0.8);
+Howler.volume(0.8);
+
+let a: Howl = new globalThis.Howl({ src: 'sound.mp3' });
+let b: HowlerGlobal = globalThis.Howler;