Skip to content

Add double scrollTo to fix List scroll restoration inconsistency #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add double scrollTo to fix List scroll restoration inconsistency #1548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00342c1
Add double scrollTo to fix scroll restoration inconsistency
carson-katri Mar 4, 2025
2b0b1b7
Show by default when scroll restoration is disabled
carson-katri Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sources/LiveViewNative/Views/Layout Containers/Collection Containers/List.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ struct List<Root: RootRegistry>: View {
}
}
}
.opacity((id == nil || didAttemptRestoration) ? 1 : 0) // prevent flickering when restoring
.task {
defer { didAttemptRestoration = true }

Expand All @@ -216,6 +217,12 @@ struct List<Root: RootRegistry>: View {
else { return }

scrollProxy.scrollTo(restoreID, anchor: .top)

// wait for the next runloop and try to scroll again
// it seems that the scroll won't work if the elements are not laid-out yet
try! await Task.sleep(for: .nanoseconds(0))

scrollProxy.scrollTo(restoreID, anchor: .top)
}
}
}
Expand Down
Loading