Merge branch 'navigation-refactor' of github.com:liveviewnative/liveview-client-swiftui into cached-navigation-title

Author: carson-katri

Sources/LiveViewNative/BuiltinRegistry.swift

@@ -47,9 +47,6 @@ struct BuiltinRegistry {
 
         case "phx-form":
             PhxForm<R>(element: element, context: context)
-        case "phx-hero":
-//            PhxHeroView(element: element, context: context)
-            fatalError()
         case "phx-submit-button":
             PhxSubmitButton(element: element, context: context)
         default:

Sources/LiveViewNative/LiveView.swift

@@ -115,6 +115,6 @@ public struct LiveView<R: CustomRegistry>: View {
     }
 
     private var navigationRoot: some View {
-        NavStackEntryView(.init(url: session.url, coordinator: rootCoordinator))
+        NavStackEntryView(.init(url: rootCoordinator.url, coordinator: rootCoordinator))
     }
 }

Sources/LiveViewNative/LiveViewNative.docc/Elements/Hero.md

@@ -19,7 +19,6 @@ LiveViewNative supports DOM elements similar to but distinct from their Web coun
 - <doc:Image>
 - <doc:AsyncImage>
 - <doc:NavigationLink>
-- <doc:Hero>
 - <doc:Button>
 
 ### Forms

Sources/LiveViewNative/LiveViewNative.docc/SupportedElements.md

@@ -21,12 +21,7 @@ struct AsyncImage<R: CustomRegistry>: View {
         SwiftUI.AsyncImage(url: url, scale: scale ?? 1, transaction: Transaction(animation: .default)) { phase in
             switch phase {
             case .success(let image):
-                let configured = configureImage(image)
-                configured
-                    // when using an AsyncImage in the hero transition overlay, it never resolves to the actual image
-                    // so when the source AsyncImage resolves, we use a preference to communicate the resulting
-                    // Image up to the overlay view, in case it needs to be used
-//                    .preference(key: HeroViewOverrideKey.self, value: HeroViewOverride(configured))
+                configureImage(image)
             case .failure(let error):
                 SwiftUI.Text(error.localizedDescription)
             case .empty:

Sources/LiveViewNative/Views/Images/AsyncImage.swift

@@ -13,8 +13,6 @@ struct NavigationLink<R: CustomRegistry>: View {
     @ObservedElement private var element: ElementNode
     private let context: LiveContext<R>
     @EnvironmentObject private var navCoordinator: NavigationCoordinator<R>
-//    @State private var source: HeroViewSourceKey.Value = nil
-//    @State private var overrideView: HeroViewOverrideKey.Value = nil
     @State private var doNavigationCancellable: AnyCancellable?
 
     init(element: ElementNode, context: LiveContext<R>) {